Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv6 Support: Bootstrap process breaks when serviceIpv6Cidr isn't provided #839

Closed
ravisinha0506 opened this issue Jan 12, 2022 · 7 comments
Labels
bug Something isn't working

Comments

@ravisinha0506
Copy link
Contributor

What happened:
When service-ipv6-cidr isn't provided to bootstrap.sh script, it makes describe-cluster api to fetch this value and receives None. This is happening as awscli still points to an older version ( 1.18.X ) which doesn't return newly introduced parameters. As a result, None gets assigned toservice-ipv6-cidr.

What you expected to happen:
Bootstrap process should be able to fetch correct service-ipv6-cidr value from eks describe-cluster api.

How to reproduce it (as minimally and precisely as possible):
Use this userdata in IPv6 variant worker node:

MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="//"

--//
Content-Type: text/x-shellscript; charset="us-ascii"
#!/bin/bash
set -ex

/etc/eks/bootstrap.sh my-cluster --ip-family ipv6

--//--
@ravisinha0506
Copy link
Contributor Author

As a workaround, all the params should be passed to the bootstrap script.

For ex:

MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="//"

--//
Content-Type: text/x-shellscript; charset="us-ascii"
#!/bin/bash
set -ex
B64_CLUSTER_CA=<CADATA>
API_SERVER_URL=<SOME_ENDPOINT>
SERVICE_IPV6_CIDR=<cidr>
/etc/eks/bootstrap.sh my-cluster --b64-cluster-ca $B64_CLUSTER_CA --apiserver-endpoint $API_SERVER_URL --ip-family ipv6 --service-ipv6-cidr  $SERVICE_IPV6_CIDR 

--//--

@ravisinha0506
Copy link
Contributor Author

Latest AMI release has fix for this issue.

@cartermckinnon cartermckinnon added the bug Something isn't working label Jan 24, 2022
@ravisinha0506 ravisinha0506 reopened this Jan 25, 2022
@ravisinha0506
Copy link
Contributor Author

ravisinha0506 commented Jan 25, 2022

This issue would still appear for a custom AMI node group customer as default AWS CLI ( v1.18 ) wouldn't be able to fetch cluster information using eks:describeCluster api.

@archoversight
Copy link

#887

The assumption is that if you pass in the b64-cluster-ca and the apiserver-endpoint then it is IPv4...

@bryantbiggs
Copy link
Contributor

I believe this is resolved with #860 - cc @bwagner5 / @suket22

@archoversight
Copy link

This issue likely won't be fixed with #860 either. This is related to the AWS CLI version being out of date. My comment above was that this is still broken if you pass just the b64 cluster ca and the apiserver endpoint, without providing the other IPv6 information.

@bwagner5
Copy link
Contributor

bwagner5 commented Feb 3, 2023

AWS CLI has been updated, so this should be resolved now #1066

@bwagner5 bwagner5 closed this as completed Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants