Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

auto discovered cluster name is not actually set #3

Open
marsel-tron opened this issue Apr 29, 2020 · 0 comments
Open

auto discovered cluster name is not actually set #3

marsel-tron opened this issue Apr 29, 2020 · 0 comments

Comments

@marsel-tron
Copy link

marsel-tron commented Apr 29, 2020

Code parses the cluster name from ec2 instance tag according to this line - https://github.com/awslabs/amazon-eks-serverless-drainer/blob/master/main.sh#L37-L38

But when setting kubeconfig, it's using cluster_name variable which is different from the parsed cluster name (input_cluster_name) - https://github.com/awslabs/amazon-eks-serverless-drainer/blob/master/main.sh#L41

By default, when you deploy with a click of a button, it doesn't set the cluster_name variable at all. And now I am wondering how is this expected to work?
Also note: The lambda function itself doesn't handle errors well and makes everything look like it has worked

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant