Caching improvement: AssumeRoleRequest used for credentialsCache's key can use a set of policy ARNs instead of a list

[yjanezou]

amazon-emr-user-role-mapper/emr-user-role-mapper-application/src/main/java/com/amazon/aws/emr/credentials/STSCredentialsProvider.java

Line 47 in e4a9c4d

private final LoadingCache<AssumeRoleRequest, Optional<EC2MetadataUtils.IAMSecurityCredential>> credentialsCache = CacheBuilder

In case the user groups fetched for the same user are returned with different order though they are same set of groups, the corresponding generated AssumeRoleRequest will be different as the order of the mapped policy ARN list will be different based on current hash/equal methods. It could cause the STS credential cache (assumeRoleRequest -> token) not used effectively.

We can either sort the user groups, or more desirable, use a set instead of a list in AssumeRoleRequest.

[a517690655]

If AssumeRoleRequest.withPolicy(stsPolicy) resource include chinese, sdk will throw an exception.Need use URLEncoder.encode(fileKey.toString(),"UTF-8"); to thransfer will pass, advice this transfer add to SDK.