Added configuration to ignore a number of ReadTimeouts before printing warnings. #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated versions to 2.1.4-SNAPSHOT (awslabs#526)
…g warnings.
Messaging now directs customer to configure the SDK with appropriate timeouts based on their processing model.
Warning messages from ShardConsumer now specify that the KCL will reattempt to subscribe to the stream as needed.
Added configuraiton to Lifecycle configuration to enable ignoring a number of ReadTimeouts before printing warning messages.
Marked original ShardConsumerSubscriber constructor as deprecated Renamed tests to be more descriptive
sahilpalvia
previously requested changes
Apr 4, 2019
...-kinesis-client/src/main/java/software/amazon/kinesis/lifecycle/ShardConsumerSubscriber.java
Outdated
Show resolved
Hide resolved
...esis-client/src/test/java/software/amazon/kinesis/lifecycle/ShardConsumerSubscriberTest.java
Outdated
Show resolved
Hide resolved
amazon-kinesis-client/src/main/java/software/amazon/kinesis/lifecycle/ShardConsumer.java
Show resolved
Hide resolved
sahilpalvia
suggested changes
Apr 4, 2019
...esis-client/src/test/java/software/amazon/kinesis/lifecycle/ShardConsumerSubscriberTest.java
Show resolved
Hide resolved
...esis-client/src/test/java/software/amazon/kinesis/lifecycle/ShardConsumerSubscriberTest.java
Outdated
Show resolved
Hide resolved
amazon-kinesis-client/src/test/java/software/amazon/kinesis/lifecycle/ShardConsumerTest.java
Show resolved
Hide resolved
amazon-kinesis-client/src/test/java/software/amazon/kinesis/lifecycle/ConsumerStatesTest.java
Outdated
Show resolved
Hide resolved
...-kinesis-client/src/main/java/software/amazon/kinesis/lifecycle/ShardConsumerSubscriber.java
Show resolved
Hide resolved
sahilpalvia
previously requested changes
Apr 4, 2019
...esis-client/src/test/java/software/amazon/kinesis/lifecycle/ShardConsumerSubscriberTest.java
Outdated
Show resolved
Hide resolved
...esis-client/src/test/java/software/amazon/kinesis/lifecycle/ShardConsumerSubscriberTest.java
Show resolved
Hide resolved
sahilpalvia
approved these changes
Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Added configuration to ignore a number of ReadTimeouts before printing warnings.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.