Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't scale up from minimum #18

Closed
szinck opened this issue May 19, 2015 · 2 comments
Closed

can't scale up from minimum #18

szinck opened this issue May 19, 2015 · 2 comments

Comments

@szinck
Copy link

szinck commented May 19, 2015

If you create a stream having $minShards, auto-scaling will not scale up even though it thinks it needs to.

I think this is due to the short circuit logic here:

https://github.com/awslabs/amazon-kinesis-scaling-utils/blob/master/src/main/java/com/amazonaws/services/kinesis/scaling/StreamScaler.java#L342-L354

Basically if numberOfShards == minShards, it will not scale up. It also looks like it will not scale down once it reaches maxShards.

Here are some logs from where I tested this:

19-May-2015 22:35:43.203 INFO [pool-1-thread-1] com.amazonaws.services.kinesis.scaling.auto.StreamMonitor.processCloudwatchMetrics Stream Used Capacity 92.82% (973,236 Bytes of 1,048,576)
19-May-2015 22:35:43.203 INFO [pool-1-thread-1] com.amazonaws.services.kinesis.scaling.auto.StreamMonitor.processCloudwatchMetrics Scale Up Stream test-stream by 2 Shards as PUT has been above 85% for 1 Minute
s
19-May-2015 22:35:43.469 INFO [pool-1-thread-1] com.amazonaws.services.kinesis.scaling.StreamScaler.scaleStream Scaling Stream test-stream from 1 Shards to 3
19-May-2015 22:35:43.686 INFO [pool-1-thread-1] com.amazonaws.services.kinesis.scaling.StreamScaler.scaleStream Minimum Shard Count of 1 Reached
@IanMeyers
Copy link
Contributor

Ah sorry about this - the integration test made an incorrect assumption. Fixed in place with a patch to .9.1.8

@szinck
Copy link
Author

szinck commented May 20, 2015

wow thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants