Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented but required configuration parameter "refreshShardsNumberAfterMin" #23

Closed
jpalay opened this issue Oct 13, 2015 · 3 comments

Comments

@jpalay
Copy link

jpalay commented Oct 13, 2015

There seems to be a configuration parameter refreshShardsNumberAfterMin which, if not set, defaults to null and causes a NullPointerException after the daemon runs for a few minutes. However, I didn't see this in the README anywhere. This ended up biting us, so maybe this should be documented to save others the trouble? Some other things that would be helpful:

  1. It'd be nice if the autoscaling daemon failed early with a helpful error message if the configuration isn't right. This would have saved us a lot of time.
  2. When a StreamMonitor fails, it'd be helpful if it printed a stack trace to make debugging what went wrong easier. I ended up adding a line just above here to log the exception from the failed StreamMonitor, which helped me debug my issue.

Let me know what you think, thanks!
-Josh

@IanMeyers
Copy link
Contributor

Hi Josh,

Apologies for this - missed that out of the documentation. Version .9.3.1 fixes this in the readme, and also adds defaults for this value (10 minutes) and for region (us-east-1).

Thanks,

Ian

@IanMeyers
Copy link
Contributor

And .9.3.2 adds configuration validation of some obvious things that might be easy to miss.

@jpalay
Copy link
Author

jpalay commented Oct 14, 2015

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants