Skip to content
This repository has been archived by the owner on Apr 19, 2023. It is now read-only.

Migrate all existing console.log to amplify logging solution context.print #25

Closed
wizage opened this issue Sep 26, 2019 · 1 comment · Fixed by #113
Closed

Migrate all existing console.log to amplify logging solution context.print #25

wizage opened this issue Sep 26, 2019 · 1 comment · Fixed by #113
Labels
good first issue Good for newcomers

Comments

@wizage
Copy link
Contributor

wizage commented Sep 26, 2019

Is your feature request related to a problem? Please describe.
Right now we use console.log and context.print throughout the project. We should move to using a single unified way of logging.

With context.print you can get easily get different colors and bolding that will be unify across amplify.

Right now Amplify supports:
info - Displays info (White)
warning - Displays a warning (Yellow)
error - Displays an error (Red)
success - Displays a success message (Green)
green - Displays text in Green
yellow - Displays text in Yellow
red - Displays text in Red
blue - Displays text in Blue (This should be used for outputs.)

Describe the solution you'd like
Replace the console.log with the respective output that you would expect. Can keep the strings the same with chalk formatting (as long as coloring is removed).

@wizage wizage added the good first issue Good for newcomers label Sep 26, 2019
@smp smp self-assigned this Nov 6, 2019
@smp
Copy link
Contributor

smp commented Nov 11, 2019

coloring should come from context.print.foo, not from chalk

@wizage wizage added this to To do in Project planning board Jan 16, 2020
@smp smp assigned smp and unassigned smp Mar 2, 2020
@wizage wizage moved this from Unsorted to To Do (CLI) in Project planning board Jun 1, 2020
Project planning board automation moved this from To Do (CLI) to Done Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Development

Successfully merging a pull request may close this issue.

2 participants