Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bokeh dependency #1055

Merged
merged 1 commit into from
Apr 11, 2021
Merged

Remove bokeh dependency #1055

merged 1 commit into from
Apr 11, 2021

Conversation

Innixma
Copy link
Contributor

@Innixma Innixma commented Apr 10, 2021

Issue #, if available:
#1051

Description of changes:

Removes bokeh dependency in autogluon.extra, which was only used optionally for plots. Since it caused numerous issues related to tornado dependencies in Kaggle (crash on importing AutoGluon), better to have it be purely optional, as a warning is shown to users who try to make plots telling them to install it.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@szha
Copy link

szha commented Apr 10, 2021

Job PR-1055-1 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1055/1/index.html

@jwmueller
Copy link
Contributor

jwmueller commented Apr 11, 2021

Should there be some easy way for users to simultaneously install all optional dependencies like bokeh and others?
It can be inconvenient to have to first encounter the error message instructing how to install each one of these optional dependencies. Might be nicer to have a full install (including all optional dependencies) available via something like this:

pip install autogluon  # installs everything except autogluon.extra
pip install autogluon.extra

If we want the ENAS code to be non-optional, then it could be in autogluon.nas subpackage, which anyway is a clearer name than .extra.

@gradientsky your thoughts?

@Innixma
Copy link
Contributor Author

Innixma commented Apr 11, 2021

Will merge for now, and we can refactor how we want to deal with generic optional dependencies in future

@Innixma Innixma merged commit 38791b8 into master Apr 11, 2021
@Innixma Innixma deleted the remove_bokeh branch April 27, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants