Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially missing test files for sigV4 #160

Closed
dnys1 opened this issue Apr 20, 2022 · 1 comment · Fixed by #232
Closed

Potentially missing test files for sigV4 #160

dnys1 opened this issue Apr 20, 2022 · 1 comment · Fixed by #232
Labels
p3 This is a minor priority issue

Comments

@dnys1
Copy link

dnys1 commented Apr 20, 2022

Hello, we are using the test suite for our SigV4 implementation. Most directories have exactly 10 files which describe the test, however the following have only 2:

Are these expected to share the missing files with another directory?

@bretambrose
Copy link
Contributor

Those were probably in the original test suite we started with. There were several tests that had flat-out wrong validation data in them and we skipped. We should remove these.

@yasminetalby yasminetalby added the p3 This is a minor priority issue label Jun 23, 2023
@jmklix jmklix linked a pull request Mar 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3 This is a minor priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants