feat(aws-ecs): Support HTTPS in load balanced Fargate service #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladb
reviewed
Nov 8, 2018
| const listener = lb.addListener('PublicListener', { port: 80, open: true }); | ||
| let listener; | ||
| if (props.certificateArn) { | ||
| // TODO once ALB redirects are supported in CloudFormation, |
clareliguori
force-pushed
the
tls-for-lb-fargate-svc
branch
from
12d0fd0
to
486a577
Compare
|
Tests should pass once #1131 is merged in |
eladb
approved these changes
Nov 12, 2018
|
You're going to have to merge from master and push again. |
eladb
reviewed
Nov 13, 2018
| "@aws-cdk/aws-route53": "^0.16.0", | ||
| "@aws-cdk/cdk": "^0.16.0", | ||
| "@aws-cdk/cx-api": "^0.16.0" | ||
| >>>>>>> upstream/master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SoManyHs @rix0rrr
Wanted to start with this one and get comments, then I'll add same functionality to the others (LB-EC2, LB-Fargate-Applet)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.