Adjust project structure and introduce pyproject.toml #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbeacom
commented
Feb 24, 2022
| #// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| #// SPDX-License-Identifier: Apache-2.0 | ||
| # AWS CloudSaga - Simulate security events in AWS | ||
| # Joshua "DozerCat" McKiddy - Customer Incident Response Team (CIRT) - AWS | ||
|
|
||
|
|
||
| import logging | ||
| import boto3 |
There was a problem hiding this comment.
Removed superfluous imports here
mbeacom
commented
Feb 24, 2022
| main() |
mbeacom
commented
Feb 24, 2022
| @@ -21,7 +21,7 @@ | |||
|
|
|||
|
|
|||
| sts = boto3.client('sts') | |||
| region = os.environ['AWS_REGION'] | |||
| region = os.environ.get('AWS_REGION', 'us-east-1') | |||
There was a problem hiding this comment.
This resolves a default workflow bombing out when attempting cloudsaga -h if AWS_REGION is not set.
mbeacom
commented
Feb 24, 2022
| python = "^3.9" | ||
| boto3 = "^1.21.7" | ||
|
|
||
| [tool.poetry.dev-dependencies] |
There was a problem hiding this comment.
These are some opinionated, common tools for formatting, linting, SAST, etc.
mbeacom
commented
Feb 24, 2022
|
|
||
| [tool.poetry.dependencies] | ||
| python = "^3.9" | ||
| boto3 = "^1.21.7" |
mbeacom
force-pushed
the
create-package
branch
from
c4a4055
to
ddf6b64
Compare
mbeacom
force-pushed
the
create-package
branch
from
ddf6b64
to
1433312
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #2
Description of changes: The goal of this PR is to format the project to conform to a standard python package and add a toplevel
pyproject.tomlto handle package/dep management, venv management, and publishing while also conforming to a versioning python package structure.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.