Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not support deployments triggered from windows environment #80

Closed
otyrrell opened this issue Mar 24, 2023 · 2 comments
Closed

Does not support deployments triggered from windows environment #80

otyrrell opened this issue Mar 24, 2023 · 2 comments

Comments

@otyrrell
Copy link

Due the the direct string replacements used to transform the absolute local path of the source files to a bundle relative path we bundle the entire local path when running in a windows environment. Suggest fixing as follows within _bundle.py:

zip_relative_path = os.path.relpath(pathlib.Path(path), pathlib.Path(root_dir)) zf.write(path, zip_relative_path)

@dgraeber
Copy link
Contributor

Thanks @otyrrell - we will look into ths.

@otyrrell
Copy link
Author

#81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants