Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 9+ Compatibility #311

Closed
MikeDombo opened this issue Apr 24, 2021 · 3 comments
Closed

Java 9+ Compatibility #311

MikeDombo opened this issue Apr 24, 2021 · 3 comments
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue

Comments

@MikeDombo
Copy link

MikeDombo commented Apr 24, 2021

https://github.com/awslabs/aws-crt-java/blob/652a6f853a35cd064dbe1dbff4aedee197991b37/src/native/java_class_ids.c#L204,L210

The ByteBuffer methods won't be able to be found on Java 9+ due to Java's changing the return type to be ByteBuffer instead of the superclass Buffer

You may need to update the code to look for what it looks for now, and then if that fails try to look for the other version.

@bretambrose
Copy link
Contributor

I'm running the samples without issue with jdk11 targeting jre11. Is there something additional that needs to be done to surface this? It appears that Buffer still has the method in question (and is probably the exact same thing really) so is it possible that the jni lookup is actually mapping to the Buffer method and everything still works?

@bretambrose bretambrose added closing-soon This issue will automatically close in 4 days unless further comments are made. response-requested Waiting on additional info and feedback. Will move to 'closing-soon' in 7 days. labels May 18, 2021
@MikeDombo
Copy link
Author

I hit this issue when building with graal native image for jdk 11.

@bretambrose bretambrose removed the closing-soon This issue will automatically close in 4 days unless further comments are made. label Jul 6, 2021
@jmklix jmklix added feature-request A feature should be added or improved. and removed response-requested Waiting on additional info and feedback. Will move to 'closing-soon' in 7 days. labels May 12, 2023
@jmklix jmklix added the p2 This is a standard priority issue label Nov 15, 2023
@jmklix
Copy link
Member

jmklix commented May 6, 2024

Closing: duplicate of this FR - #780

@jmklix jmklix closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

3 participants