Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Python in JSII and upgrade CDK version #148

Merged
merged 3 commits into from Aug 19, 2022

Conversation

LeonLuttenberger
Copy link
Contributor

Detail

  • Upgraded CDK version to v2.34.0
  • Added configuration for JSII to generate Python objects
  • Changed module name to aws-cdk-core, to reflect the name of the Python package.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@LeonLuttenberger LeonLuttenberger added dependencies Pull requests that update a dependency file typescript labels Aug 18, 2022
@LeonLuttenberger LeonLuttenberger added this to the 1.0.0 milestone Aug 18, 2022
@LeonLuttenberger LeonLuttenberger self-assigned this Aug 18, 2022
@LeonLuttenberger LeonLuttenberger added this to In Review in Roadmap Aug 18, 2022
.projen/deps.json Outdated Show resolved Hide resolved
Copy link
Contributor

@malachi-constant malachi-constant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I left a couple comments but nothing pressing.

Copy link
Contributor

@kukushking kukushking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I would just go for it and enable other languages too.

@LeonLuttenberger LeonLuttenberger merged commit c6343fc into typescript-conversion Aug 19, 2022
@LeonLuttenberger LeonLuttenberger deleted the typescript-jsii-python branch August 19, 2022 13:44
@malachi-constant malachi-constant moved this from In Review to Done in Roadmap Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core dependencies Pull requests that update a dependency file typescript
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants