Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix typescript s3 event pattern #149

Merged
merged 3 commits into from Aug 19, 2022
Merged

fix: Fix typescript s3 event pattern #149

merged 3 commits into from Aug 19, 2022

Conversation

kukushking
Copy link
Contributor

Feature or Bugfix

  • Bugfix

Detail

When deploying a data pipeline using s3 event stage, the deployment fails with:

Event pattern is not valid. Reason: "name" must be an object or an array at [Source: (String)"{"detail-type":["Object Created"],"source":["aws.s3"],"detail":{"bucket":{"name":"sampleappstack-bucket43879c71-1wm0hdcs3ct4o"}}}"; line: 1, column: 83] (Service: AmazonCloudWatchEvents; Status Code: 400; Error Code: InvalidEventPatternException; Request ID: 6a822040-d24e-439a-8d2e-4addb58f33fb; Proxy: null)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kukushking kukushking added bug Something isn't working core labels Aug 19, 2022
@kukushking kukushking self-assigned this Aug 19, 2022
@kukushking kukushking changed the base branch from main to typescript-conversion August 19, 2022 10:49
@kukushking kukushking changed the title Typescript fix s3 event pattern fix: Fix typescript s3 event pattern Aug 19, 2022
LeonLuttenberger
LeonLuttenberger approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@LeonLuttenberger LeonLuttenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes, thanks for catching that.

@malachi-constant malachi-constant merged commit fb33536 into typescript-conversion Aug 19, 2022
@malachi-constant malachi-constant deleted the typescript-fix-s3-event-pattern branch August 19, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malachi-constant malachi-constant malachi-constant approved these changes

@LeonLuttenberger LeonLuttenberger LeonLuttenberger approved these changes

Assignees

@kukushking kukushking

Labels
bug Something isn't working core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kukushking @malachi-constant @LeonLuttenberger