Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github Workflow: CFN Nag #18

Merged
merged 5 commits into from Feb 25, 2022
Merged

Github Workflow: CFN Nag #18

merged 5 commits into from Feb 25, 2022

Conversation

malachi-constant
Copy link
Contributor

Subject: Adding Github Workflow: CFN Nag

Feature or Bugfix

  • Feature: Adding Github Workflow: CFN Nag

Relates

  • General Workflow Setup

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant malachi-constant self-assigned this Feb 21, 2022
@malachi-constant malachi-constant changed the title Github Workflow: CFN Nag Draft: Github Workflow: CFN Nag Feb 21, 2022
@malachi-constant malachi-constant marked this pull request as draft February 21, 2022 23:02
@jaidisido
Copy link
Contributor

Brainstorming here - I suppose the difficulty will be how to synthesize meaningful DDK applications against which to run CFN Nag

@malachi-constant
Copy link
Contributor Author

@jaidisido Yep exactly. If there's away to write tests (instantiation) of the default stage patterns of themselves generically I think we could at least get a little value. But, running cfn-nag on the bootstrap template (which i assume won't change) doesn't add much value.

@jaidisido jaidisido added this to To Do in Roadmap Feb 25, 2022
@malachi-constant malachi-constant moved this from To Do to Review in Roadmap Feb 25, 2022
@malachi-constant malachi-constant marked this pull request as ready for review February 25, 2022 18:16
@malachi-constant
Copy link
Contributor Author

Will add writing examples for DDK stages to the backlog to enable security scanning down the line.

@malachi-constant malachi-constant merged commit aaa6d35 into main Feb 25, 2022
@malachi-constant malachi-constant moved this from Review to Done in Roadmap Feb 25, 2022
@malachi-constant malachi-constant changed the title Draft: Github Workflow: CFN Nag Github Workflow: CFN Nag Feb 25, 2022
@malachi-constant malachi-constant deleted the cfn-nag branch February 28, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@malachi-constant malachi-constant

Labels
None yet
Projects
Roadmap
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@malachi-constant @jaidisido