Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revirew & upgrade CDK alpha packages to official #189

Closed
kukushking opened this issue Dec 6, 2022 · 3 comments
Closed

Revirew & upgrade CDK alpha packages to official #189

kukushking opened this issue Dec 6, 2022 · 3 comments
Assignees
@malachi-constant
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
Roadmap

Comments

@kukushking
Copy link
Contributor

We still rely on a couple of alpha packages:
"aws-cdk.aws-glue-alpha" = "^2.20.0a0" "aws-cdk.aws-kinesisfirehose-alpha" = "^2.20.0a0" "aws-cdk.aws-kinesisfirehose-destinations-alpha" = "^2.20.0a0"

Looks like official kinesisfirehose package is available.

We should review which alpha packages we can deprecate and update the code to use official CDK packages.

P.S. Don't attach files. Please, prefer add code snippets directly in the message body.
@kukushking kukushking added the enhancement New feature or request label Dec 6, 2022
@malachi-constant malachi-constant self-assigned this Dec 6, 2022
@malachi-constant malachi-constant added the dependencies Pull requests that update a dependency file label Dec 6, 2022
@malachi-constant malachi-constant added this to the 0.7.0 milestone Dec 6, 2022
@malachi-constant malachi-constant added this to To Do in Roadmap Dec 6, 2022
@malachi-constant
Copy link
Contributor

@kukushking The package linked is just L1 constructs, so we'll still need to rely on the alpha packages. I checked the other two and same case for them as well.

There are no official hand-written (L2) constructs for this service yet. Here are some suggestions on how to proceed:

@malachi-constant malachi-constant moved this from To Do to In Progress in Roadmap Dec 7, 2022
@malachi-constant
Copy link
Contributor

I'll take the opportunity to do upgrade cdk -> 2.54.0 though.

@malachi-constant malachi-constant moved this from In Progress to Done in Roadmap Dec 7, 2022
@kukushking
Copy link
Contributor Author

Thanks! @malachi-constant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malachi-constant malachi-constant

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
Roadmap
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kukushking @malachi-constant