Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Integration Testing #235

Merged
merged 8 commits into from Jan 31, 2023
Merged

feat: Integration Testing #235

merged 8 commits into from Jan 31, 2023

Conversation

malachi-constant
Copy link
Contributor

@malachi-constant malachi-constant commented Jan 27, 2023 •
edited

Details

  • Starts DDK Integration Testing #164
  • This PR is meant as a proof-of-concept on building out integration tests. If we move forward with this strategy we'll open a PR to write the remaining necessary tests for DDK Integration Testing #164.
  • I'd also recommend we pull our repo internally and run all integration tests against internal accounts so we can avoid configuring credentials with extensive permissions in GIthub.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant malachi-constant self-assigned this Jan 27, 2023
@malachi-constant malachi-constant changed the title Draft: Integration Testing Draft: feat: Integration Testing Jan 27, 2023
@malachi-constant
Copy link
Contributor Author

malachi-constant commented Jan 27, 2023 •
edited

Interesting that yarn.lock update is no longer complaining. RE: #232 @LeonLuttenberger

Possibly the action version updates in the workflows may have handled...

@malachi-constant malachi-constant changed the title Draft: feat: Integration Testing feat: Integration Testing Jan 30, 2023
@malachi-constant malachi-constant added this to the 1.0.0 milestone Jan 30, 2023
@malachi-constant malachi-constant added this to In Review in Roadmap Jan 30, 2023
@malachi-constant malachi-constant mentioned this pull request Jan 30, 2023
Closed
LeonLuttenberger
LeonLuttenberger requested changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@LeonLuttenberger LeonLuttenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overrall looks good! I think this is a good approach.

I wonder if we can make this run as part of our GitHub workflow somehow.

integ/integ.s3-event.ts Outdated Show resolved Hide resolved
integ/integ.kinesis-s3-stage.test.ts Outdated Show resolved Hide resolved
.projenrc.js Outdated Show resolved Hide resolved
@malachi-constant malachi-constant merged commit 6c2ba10 into typescript-conversion Jan 31, 2023
@malachi-constant malachi-constant deleted the 164-integration-testing branch January 31, 2023 16:49
@malachi-constant malachi-constant moved this from In Review to Done in Roadmap Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonLuttenberger LeonLuttenberger LeonLuttenberger approved these changes

@jaidisido jaidisido Awaiting requested review from jaidisido

@cnfait cnfait Awaiting requested review from cnfait

@kukushking kukushking Awaiting requested review from kukushking

Assignees

@malachi-constant malachi-constant

Labels
testing
Projects
Roadmap
Done
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@malachi-constant @LeonLuttenberger