Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move getEnvConfig() to static method #270

Merged
merged 2 commits into from Mar 3, 2023

Conversation

malachi-constant
Copy link
Contributor

@malachi-constant malachi-constant commented Mar 2, 2023

We now have two ways of retrieving data from config.

  1. Class method
// Instantiate Config
const config = new Configurator({ configPath: "./ddk.yaml", environmentId: "dev" });

// Retrive Values from Object
config.getConfigAttribute("foo")
  1. static method -- no object state
// Retrieve data directly from file
const config = Configurator.getEnvConfig({ configPath: "./test/test-config.yaml", environmentId: "dev" });

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant malachi-constant changed the base branch from main to typescript-conversion March 2, 2023 23:20
@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
  • Commit ID: b96c6d3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant malachi-constant merged commit 06d19e1 into typescript-conversion Mar 3, 2023
@malachi-constant malachi-constant deleted the fix/config-methods branch March 3, 2023 00:14
@malachi-constant malachi-constant added this to In Review in Roadmap Mar 6, 2023
@malachi-constant malachi-constant moved this from In Review to Done in Roadmap Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants