Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cicd environment support #280

Merged
merged 3 commits into from Mar 21, 2023
Merged

fix: cicd environment support #280

merged 3 commits into from Mar 21, 2023

Conversation

malachi-constant
Copy link
Contributor

Fix to close #277

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant malachi-constant added bug Something isn't working core typescript labels Mar 21, 2023
@malachi-constant malachi-constant added this to the 1.0.0 milestone Mar 21, 2023
@malachi-constant malachi-constant self-assigned this Mar 21, 2023
@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
  • Commit ID: 560bf12
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant malachi-constant mentioned this pull request Mar 21, 2023
Closed
@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
  • Commit ID: cfa9309
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

anmolsgandhi
anmolsgandhi approved these changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@anmolsgandhi anmolsgandhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good !

@malachi-constant malachi-constant linked an issue Mar 21, 2023 that may be closed by this pull request
CICD Multi Account or Multi Region Deployment Fails #277
Closed
@malachi-constant malachi-constant merged commit dbc8bfc into typescript-conversion Mar 21, 2023
@malachi-constant malachi-constant deleted the fix/227 branch March 21, 2023 21:41
@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
  • Commit ID: 08e4620
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmolsgandhi anmolsgandhi anmolsgandhi approved these changes

@LeonLuttenberger LeonLuttenberger Awaiting requested review from LeonLuttenberger

@cnfait cnfait Awaiting requested review from cnfait

@jaidisido jaidisido Awaiting requested review from jaidisido

@kukushking kukushking Awaiting requested review from kukushking

Assignees

@malachi-constant malachi-constant

Labels
bug Something isn't working core typescript
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

CICD Multi Account or Multi Region Deployment Fails
2 participants
@malachi-constant @anmolsgandhi