Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: getEnvironment() #307

Merged
merged 2 commits into from Apr 17, 2023
Merged

feat: getEnvironment() #307

merged 2 commits into from Apr 17, 2023

Conversation

malachi-constant
Copy link
Contributor

@malachi-constant malachi-constant commented Apr 17, 2023 •
edited

Enhancement

  • Simplify CDK environment pull from config with:
    • getEnvironment()
    • Configurator.getEnvironment()
      By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant malachi-constant added this to the 1.0.0 milestone Apr 17, 2023
@malachi-constant malachi-constant self-assigned this Apr 17, 2023
@malachi-constant malachi-constant added this to In Progress in Roadmap Apr 17, 2023
@malachi-constant malachi-constant marked this pull request as draft April 17, 2023 20:05
@malachi-constant malachi-constant moved this from In Progress to In Review in Roadmap Apr 17, 2023
@malachi-constant malachi-constant added enhancement New feature or request core labels Apr 17, 2023
@malachi-constant malachi-constant marked this pull request as ready for review April 17, 2023 20:13
@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
  • Commit ID: e22debe
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant malachi-constant merged commit 98bd743 into typescript-conversion Apr 17, 2023
7 checks passed
@malachi-constant malachi-constant deleted the feat/config-getaccountregion branch April 17, 2023 20:40
@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
  • Commit ID: 18fbdac
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant malachi-constant moved this from In Review to Done in Roadmap Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonLuttenberger LeonLuttenberger LeonLuttenberger approved these changes

@kukushking kukushking Awaiting requested review from kukushking

@jaidisido jaidisido Awaiting requested review from jaidisido

@anmolsgandhi anmolsgandhi Awaiting requested review from anmolsgandhi

@cnfait cnfait Awaiting requested review from cnfait

Assignees

@malachi-constant malachi-constant

Labels
core enhancement New feature or request
Projects
Roadmap
Done
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@malachi-constant @LeonLuttenberger