Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: account/region determination in getStackSynthesizer #347

Merged
merged 4 commits into from
Jun 13, 2023
Merged

fix: account/region determination in getStackSynthesizer #347

merged 4 commits into from
Jun 13, 2023

Conversation

malachi-constant
Copy link
Contributor

Fixes #345

  • Adds logic to determine acccount and region from configuration within getStackSynthesizer
  • Adds test for the above

@malachi-constant malachi-constant linked an issue Jun 12, 2023 that may be closed by this pull request
config: Bootstrap within multiple different regions for different environments #345
Closed
@malachi-constant malachi-constant changed the title fix account/region determination in getStackSynthesizer fix: account/region determination in getStackSynthesizer Jun 12, 2023
@malachi-constant malachi-constant self-assigned this Jun 12, 2023
@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
  • Commit ID: d0af3ab
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

chore: self mutation
5650be6 
Signed-off-by: github-actions <github-actions@github.com>
@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
  • Commit ID: 5650be6
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
updating how-to with note about account/region
037776c
@malachi-constant
Merge branch '345-config-bootstrap-within-multiple-different-regions-…
cf62b7f 
…for-different-environments' of github.com:awslabs/aws-ddk into 345-config-bootstrap-within-multiple-different-regions-for-different-environments
@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
  • Commit ID: cf62b7f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant malachi-constant added the bug Something isn't working label Jun 12, 2023
@malachi-constant malachi-constant added this to the 1.1.0 milestone Jun 12, 2023
@malachi-constant malachi-constant merged commit 34dbe7e into main Jun 13, 2023
6 checks passed
@malachi-constant malachi-constant deleted the 345-config-bootstrap-within-multiple-different-regions-for-different-environments branch June 13, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonLuttenberger LeonLuttenberger LeonLuttenberger approved these changes

@anmolsgandhi anmolsgandhi Awaiting requested review from anmolsgandhi

Assignees

@malachi-constant malachi-constant

Labels
bug Something isn't working
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

config: Bootstrap within multiple different regions for different environments
2 participants
@malachi-constant @LeonLuttenberger