Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(core): add_notifications method does not send notifications as expected #62

Closed
jaidisido opened this issue Mar 24, 2022 · 3 comments
Closed
Assignees
Labels
bug Something isn't working core p1
Projects

Comments

@jaidisido
Copy link
Contributor

Describe the bug

add_notifications method in CICDPipelineStack creates the CodeStar notification but no notification is sent when the CodePipeline pipeline fails

How to Reproduce

  1. Create a DDK CICD pipeline and add notifications
CICDPipelineStack(
...
.add_notifications()
  1. An SNS topic should be created. Subscribe your email address to it
  2. Fail the pipeline. The user expects an email to be sent but it never arrives

Expected behavior

An email is sent when the Pipeline fails

Your project

No response

Screenshots

No response

Environment

Provide your `pip list` output, particularly the version of the AWS DDK library you used. Providing this information may significantly improve resolution times.

OS

Mac

Python version

3.7

AWS DDK version

0.2.1

Additional context

No response

@jaidisido jaidisido added the bug Something isn't working label Mar 24, 2022
@malachi-constant
Copy link
Contributor

I imagine there's some issues with the SNS topic policy created, will investigate. Thanks for identifying..

@malachi-constant malachi-constant added this to the 0.3.0 milestone Mar 24, 2022
@malachi-constant malachi-constant added this to In Progress in Roadmap Mar 24, 2022
@malachi-constant
Copy link
Contributor

Hmm @jaidisido I'm not able to replicate
Screen Shot 2022-03-25 at 3 57 19 PM
Screen Shot 2022-03-25 at 3 58 04 PM

@malachi-constant malachi-constant moved this from In Progress to Review in Roadmap Mar 25, 2022
@malachi-constant malachi-constant removed this from the 0.3.0 milestone Mar 25, 2022
@malachi-constant
Copy link
Contributor

Functionality confirmed working, unable to replicate.

@malachi-constant malachi-constant moved this from Review to Done in Roadmap Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core p1
Projects
Development

No branches or pull requests

2 participants