Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support overriding stack name #122

Closed
benbridts opened this issue Aug 5, 2019 · 3 comments · Fixed by #154
Closed

Support overriding stack name #122

benbridts opened this issue Aug 5, 2019 · 3 comments · Fixed by #154
Labels
enhancement New feature or request
Milestone

Comments

@benbridts
Copy link
Contributor

benbridts commented Aug 5, 2019

I added these changes to the cc-cloudformation.yml.j2 in my own reepo, to add support to specifying the CloudFormation StackName: 664d6af

If there are no objections I'd like to:

  • Add the same parameter to every jinja file
  • Document this in the user guide

I'm opening this issue to figure out if this is the preferred approach / would be accepted before doing the bulk of the effort.

@benbridts
Copy link
Contributor Author

Another approach might be to check if StackPrefix is empty, and if it is to remove the leading -, but that will generate a more complicated !If.

Moving the - to the StackPrefix might be possible too, but that would be a breaking change (for people using their own prefix)

@benbridts
Copy link
Contributor Author

I have been thinking about this more, and you night also want this to be a parameter in the targets section. Because that would allow for custom naming where needed, and deploying the same stack multiple times in the same account.

Eg:

targets:
  - name: 111111111111
    stack_name: my-stack-test
  - name: 11111111111
    stack_name: my-stack-prod

@bundyfx bundyfx added the enhancement New feature or request label Aug 7, 2019
@bundyfx
Copy link
Contributor

bundyfx commented Aug 7, 2019

Nice one, I also think this is the right way to go, stack name should be configurable in the targets section, Also I agree that we need to move the - to the stack prefix itself.

@bundyfx bundyfx added this to the 1.3.0 milestone Aug 24, 2019
@bundyfx bundyfx mentioned this issue Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants