Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Introduce an ADF pipeline region SSM Parameter store value in raw form #620

Open
1 task done
pergardebrink opened this issue Mar 14, 2023 · 0 comments
Open
1 task done

Comments

@pergardebrink
Copy link
Contributor

Describe the feature

The current value for /deployment/<adf_project>/regions SSM parameter is a "python string representation" of an array of strings, that looks something like: ['us-east-1','us-east-2','eu-west-1']

There should be an alternate value that is in "raw" comma-separated form, like: us-east-1,us-east-2,eu-west-1 to avoid having to parse the array characters or string quotes

Use Case

I want to use the value as part of an adaption for CDK using ADF pipelines I'm building, where I need to find out all the regions a pipeline is targeting (in order to push assets (file or image assets) into all regions.

I could of course strip the current value already today (which I'm currently doing), but it would be nice if I didn't have to do that and use the value directly.

Proposed Solution

I am open for providing a pull request to implement the feature if it's accepted.

I was thinking about something like this appended in this function:

parameter_store.put_parameter(
        f"/deployment/{deployment_map_source}/{pipeline.name}/region_names",
        ",".join(pipeline.get_all_regions()),
    )

Acknowledgements

  • I may be able to implement this feature request
@pergardebrink pergardebrink changed the title [Feat]: Introduce a ADF pipeline region SSM Parameter store value in raw form [Feat]: Introduce an ADF pipeline region SSM Parameter store value in raw form Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant