Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: deploy multiple SCPs to a single OU or account #724

Open
1 task done
itsnotsagar opened this issue May 13, 2024 · 6 comments
Open
1 task done

[Feat]: deploy multiple SCPs to a single OU or account #724

itsnotsagar opened this issue May 13, 2024 · 6 comments

Comments

@itsnotsagar
Copy link

itsnotsagar commented May 13, 2024

Describe the feature

Hi Team,

Is it possible to deploy multiple SCPs to a OU or account via ADF, I think at the moment we can only deploy 1 SCP per OU that too has a maximum possible file size of ~5KB.
Is there any ETA when such a feature will be added to the upcoming ADF versions?

This is our OU structure (example) -
/adf-bootstrap

  • ou1
    • scp.json
    • sub ou 1
      -scp.json
  • ou2
    • scp.json

Can we have something like this -
/adf-bootstrap

  • ou1
    • scp.json
    • scp.json
    • sub ou 1
      -scp.json
  • ou2
    • scp.json
    • scp.json

Use Case

This will allow the user to deploy multiple SCPs per OU/account as at the moment only one SCP is allowed which has a upper limit on the file size ~5KB

Proposed Solution

No response

Acknowledgements

  • I may be able to implement this feature request
@sbkok
Copy link
Collaborator

sbkok commented May 17, 2024

@StewartW submitted a pull request (PR) #551 that aimed to refactor the AWS Service Control Policy (SCP) logic in the ADF. I believe this PR intended to introduce support for managing multiple SCPs per AWS account through Policy Campaigns.

While this PR initially showed promise, it lost momentum over time due to lack of active development. To incorporate the changes, the PR would need to be rebased and updated to align with the latest codebase. Unfortunately, this effort did not meet the cut-off deadline for the v4.0 release.

However, the ADF team recognizes the importance of this feature, and plans to revisit it in a future minor release. Supporting multiple SCPs per account remains a valuable enhancement for improving account management and security controls within the ADF ecosystem.

@itsnotsagar
Copy link
Author

itsnotsagar commented May 18, 2024

Thanks for the update @sbkok. I am working on adding this feature for my own use case, I can create a PR once I am done. If possible can you include it in the next major release.

@StewartW
Copy link
Contributor

@sbkok @itsnotsagar
I was going to rebase after V4 was released (same with the event bus feature) but if @itsnotsagar can contribute, I'm happy to write off this work

@sbkok
Copy link
Collaborator

sbkok commented May 18, 2024

I appreciate the prior work done by @StewartW on the PR #551 to support multiple SCPs per account through Policy Campaigns. This seems like a promising approach to address the requested feature and overcome the current limitations.

@itsnotsagar, I would encourage you to review the implementation details and the proposed Policy Campaigns concept in that PR. If you believe it could solve your use case for managing multiple SCPs within an OU or account, please share your thoughts and any additional requirements you may have.

It's essential to ensure that the proposed solution fully meets the needs of the community. I'm open to further discussion and refinements to the approach if needed.

@itsnotsagar
Copy link
Author

@sbkok I had a look at #551, this process to support multiple SCPs seems a little confusing and unnecessary, it can be done in a simpler manner. I have already implemented this feature and have begun testing it, I will update you guys once I am done.

@itsnotsagar
Copy link
Author

@sbkok can you review this PR #735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants