-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create CodeCommit repo from deployment_map entry #88
Comments
Agreed I think the repo should be automatically created if using CodeCommit as a source, we have the account Id and we know the repo name so this makes sense. I think this would be best as the default if using CodeCommit, I cannot see a scenario when you would not want the repo created. Should we bother with the 'create-repo' key? |
It might be that users want to create the repo them selfs using CF and including event lambdas and stuff. Also for backwards compatibility but for that we could check if the repo exists with an api call. |
Ok, I like the idea. Maybe we should make it the default then, and it can be opt out of with:
|
+1 We currently use a seperate ADF managed pipeline that just churns out CodeCommit repositories including some IAM Roles that prevents pushing directly to master. Recently AWS CodeCommit allows you to provide initial content (e.g. README.md and .gitignore templates) by pointing to a zip file on an s3 bucket. Would be great if this can be made possible through ADF as well. We could add another parameter pointing to the zip file:
|
Something else, shouldn't the create-repo parameter fit better in the params section like so: pipelines:
- name: my-sample-app
type: cc-cloudformation
params:
- create-repo: true
- initial-repo-content: arn::s3:mybucket/initialrepocontent.zip |
After reading this thread I actually think you either want to have ADF create your repos or you dont. I dont really see that you want it to manage some of them. So I actually think a global But I really do like the idea of adding initial commit through a configurable endpoint. |
Perhaps, I don’t think the deployment map supports any global config parameters at the moment. I do feel you want to be able to have different initial commit for repos created with ADF so that should not be a global param. |
I would really like to simplify creation of a new repo to make it "one click to get repo and pipe".
By adding a "create-repo: true" attribute ADF should be able to create a code commit repo by launching a CF in the SourceAccount. The CF could be a template provided by the pipeline generator repo so that users can extend it.
The text was updated successfully, but these errors were encountered: