Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logger-utils): regression on exclude set leading to no formatter #1080

Conversation

mploski
Copy link
Contributor

@mploski mploski commented Mar 18, 2022

Issue #, if available:

#1073

Description of changes:

Ensure proper loggers are excluded from config propagation

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 18, 2022
@github-actions github-actions bot added the bug Something isn't working label Mar 18, 2022
@mploski mploski changed the title fix(logger-utils):fix wrong exclude list composed while copying config to external loggers fix(logger-utils): fix wrong exclude list composed while copying config to external loggers Mar 18, 2022
@heitorlessa heitorlessa changed the title fix(logger-utils): fix wrong exclude list composed while copying config to external loggers fix(logger-utils): regression on exclude set leading to no formatter Mar 18, 2022
@heitorlessa heitorlessa merged commit aef767c into aws-powertools:develop Mar 18, 2022
@mploski mploski deleted the fix/wrong-exclude-list-in-copy-config-to-registered-loggers branch March 18, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants