Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(dev-deps): bump lerna from 4.x to 5.x #1014

Merged
merged 1 commit into from Jul 8, 2022

Conversation

dreamorosi
Copy link
Contributor

@dreamorosi dreamorosi commented Jul 8, 2022

Description of your changes

This PR bumps lerna to the latest version which includes updates to dependencies that will fix one of the security advisories that we have standing.

Warning
This is a major version upgrade. Among the changes in this version there is discontinued support for Node.js 12.x. It's not clear on whether the discontinued support refers to the development environment or the released version since out CI/CD seems to be working fine.
Nevertheless I'm calling this out to draw attention to this since there are some workflows that we won't be able to test as part of the PR review (i.e. release)

How to verify this change

See results of GH Actions that use lerna (most/all of them)

Related issues, RFCs

N/A

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

Breaking change checklist

N/A


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi self-assigned this Jul 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

📊 Package size report   No changes

File Before After
Total (Includes all files) 140.7 kB 140.7 kB
Tarball size 139.5 kB 0.02%↑139.6 kB
Unchanged files
File Size
aws-lambda-powertools-commons-0.11.1-rc.0.tgz 6.5 kB
aws-lambda-powertools-logger-0.11.1-rc.0.tgz 23.8 kB
aws-lambda-powertools-metrics-0.11.1-rc.0.tgz 17.5 kB
aws-lambda-powertools-tracer-0.11.1-rc.0.tgz 21.5 kB
commons-bundle.zip 7.1 kB
logger-bundle.zip 24.3 kB
metrics-bundle.zip 18.1 kB
tracer-bundle.zip 22.0 kB

🤖 This report was automatically generated by pkg-size-action
(options hash: 9a70d5deccd4a794f24b88821054ea2f)

@dreamorosi dreamorosi added this to Pull Requests - Work in progress in Pull Requests via automation Jul 8, 2022
@dreamorosi dreamorosi added the dependencies Changes that touch dependencies, e.g. Dependabot, etc. label Jul 8, 2022
Pull Requests automation moved this from Pull Requests - Work in progress to Pull Requests - Approved and ready to be merged Jul 8, 2022
@dreamorosi dreamorosi merged commit f4bc324 into main Jul 8, 2022
Pull Requests automation moved this from Pull Requests - Approved and ready to be merged to Pull Requests - Merged or Closed Jul 8, 2022
@dreamorosi dreamorosi deleted the build_dev_deps_bump_lerna_from_4.x_to_5.x branch July 8, 2022 12:15
saragerion added a commit that referenced this pull request Jul 14, 2022
saragerion added a commit that referenced this pull request Jul 14, 2022
dreamorosi added a commit that referenced this pull request Aug 2, 2022
dreamorosi pushed a commit that referenced this pull request Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes that touch dependencies, e.g. Dependabot, etc.
Projects
No open projects
Pull Requests
Pull Requests - Merged or Closed
Development

Successfully merging this pull request may close these issues.

None yet

3 participants