Feature: .NET Core 2.0/2.1 debugging support #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feature/dotnetcore-debugging-simple
|
Thanks for adding this, its a very exciting feature, with zero changes in SAM CLI's logic itself. 🎆 |
sriram-mv
approved these changes
Dec 4, 2018
|
This is waiting on #823 to finish building so we can fix the build. I will update and merge this in once I have that complete. |
jfuss
reviewed
Dec 4, 2018
| @@ -289,8 +297,9 @@ def _get_entry_point(runtime, debug_options=None): | |||
|
|
|||
| @staticmethod | |||
| def _supported_runtimes(): | |||
| return {Runtime.java8.value, Runtime.go1x.value, Runtime.nodejs.value, Runtime.nodejs43.value, | |||
| Runtime.nodejs610.value, Runtime.nodejs810.value, Runtime.python27.value, Runtime.python36.value} | |||
| return {Runtime.java8.value, Runtime.dotnetcore20.value, Runtime.dotnetcore21.value, Runtime.go1x.value, | |||
|
@ndobryanskyy We need to wait for the docker-lambda change right? |
|
@jfuss right. I will get back to you as soon as lambci/docker-lambda#130 is merged. Thanks for your feedback and help @sanathkr @thesriram @jfuss I really appreciate that! I'll fix minor issue with .rst here with unnecessary `` and update the doc PR with our latest findings |
… feature/dotnetcore-debugging-simple
…com/ndobryanskyy/aws-sam-cli into feature/dotnetcore-debugging-simple
|
Fixed small code formatting issue. |
|
lambci/docker-lambda#130 Merged 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#500 -> #568
Description of changes:
Enabled .NET Core debugging by adding corresponding to lambci/docker-lambda#130 entry point override utilizing
--debugger-spin-wait.Also updated corresponding document any comments and suggestions are welcome as always.
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.