New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: .NET Core 2.0/2.1 debugging support #825

Merged
merged 8 commits into from Dec 5, 2018

Conversation

Projects
None yet
4 participants
@ndobryanskyy
Copy link
Contributor

ndobryanskyy commented Dec 4, 2018

Issue #, if available:
#500 -> #568

Description of changes:

Enabled .NET Core debugging by adding corresponding to lambci/docker-lambda#130 entry point override utilizing --debugger-spin-wait.

Also updated corresponding document any comments and suggestions are welcome as always.

Checklist:

  • Write Design Document #759
  • Fix unit tests
  • Write/update functional tests. Do I need to add any?
  • Write/update integration tests. Do I need to add any?
  • make pr passes
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sanathkr
Copy link
Contributor

sanathkr left a comment

LGTM.

@TheSriram

This comment has been minimized.

Copy link
Contributor

TheSriram commented Dec 4, 2018

Thanks for adding this, its a very exciting feature, with zero changes in SAM CLI's logic itself. 🎆

@TheSriram TheSriram self-requested a review Dec 4, 2018

@jfuss

This comment has been minimized.

Copy link
Contributor

jfuss commented Dec 4, 2018

This is waiting on #823 to finish building so we can fix the build. I will update and merge this in once I have that complete.

@@ -289,8 +297,9 @@ def _get_entry_point(runtime, debug_options=None):

@staticmethod
def _supported_runtimes():
return {Runtime.java8.value, Runtime.go1x.value, Runtime.nodejs.value, Runtime.nodejs43.value,
Runtime.nodejs610.value, Runtime.nodejs810.value, Runtime.python27.value, Runtime.python36.value}
return {Runtime.java8.value, Runtime.dotnetcore20.value, Runtime.dotnetcore21.value, Runtime.go1x.value,

This comment has been minimized.

@jfuss

jfuss Dec 4, 2018

Contributor

🎉

@jfuss

This comment has been minimized.

Copy link
Contributor

jfuss commented Dec 4, 2018

@ndobryanskyy We need to wait for the docker-lambda change right?

@ndobryanskyy

This comment has been minimized.

Copy link
Contributor

ndobryanskyy commented Dec 4, 2018

@jfuss right. I will get back to you as soon as lambci/docker-lambda#130 is merged.

Thanks for your feedback and help @sanathkr @TheSriram @jfuss I really appreciate that!

I'll fix minor issue with .rst here with unnecessary `` and update the doc PR with our latest findings

@ndobryanskyy

This comment has been minimized.

Copy link
Contributor

ndobryanskyy commented Dec 4, 2018

Fixed small code formatting issue.

@ndobryanskyy

This comment has been minimized.

Copy link
Contributor

ndobryanskyy commented Dec 5, 2018

@TheSriram TheSriram merged commit 100920e into awslabs:develop Dec 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

j0lly added a commit to j0lly/aws-sam-cli that referenced this pull request Dec 15, 2018

Feature: .NET Core 2.0/2.1 debugging support (awslabs#825)
* Enable .NET Core debugging

* Minor improvements

* Fix code formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment