Static assets #76
Merged
Static assets #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanathkr
reviewed
Aug 18, 2017
| @@ -66,6 +67,11 @@ func main() { | |||
| Usage: "Optional logfile to send runtime logs to", | |||
| }, | |||
| cli.StringFlag{ | |||
| Name: "static-dir, s", | |||
| Usage: "Any static assets (e.g. CSS/Javascript/HTML) files located in this directory will be presented at /", | |||
There was a problem hiding this comment.
Can you eloborate what / refers to? Something like "mounted at / of API gateway URL"
sanathkr
approved these changes
Aug 18, 2017
|
|
||
| // Mount static files | ||
| if c.String("static-dir") != "" { | ||
| public, err := getWorkingDir(baseDir, c.String("static-dir"), checkWorkingDirExist) |
There was a problem hiding this comment.
rename public variable to static for consistency
| log.Printf("WARNING: Could not mount static files: %s\n", err) | ||
| } else { | ||
| fmt.Fprintf(os.Stderr, "Mounting static files from %s at /\n", public) | ||
| router.PathPrefix("/").Handler(http.FileServer(http.Dir(public))) |
There was a problem hiding this comment.
people might ask for a static path prefix override real soon.
|
Merging this now to cut a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements new
--static-dirCLI flag that defaults topublic/.Fixes #41