Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request]: Anonymous Credentials Provider #425

Closed
seddonm1 opened this issue Jan 23, 2022 · 10 comments
Closed

[request]: Anonymous Credentials Provider #425

seddonm1 opened this issue Jan 23, 2022 · 10 comments
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue

Comments

@seddonm1
Copy link

seddonm1 commented Jan 23, 2022

Community Note

Please upvote this issue by reacting with 馃憤馃徎 to help us prioritize!

Tell us about your request

The Java SDK has an Anonymous Credentials Provider (https://github.com/aws/aws-sdk-java-v2/blob/master/core/auth/src/main/java/software/amazon/awssdk/auth/credentials/AnonymousCredentialsProvider.java) which allows accessing AWS Open Data like (https://registry.opendata.aws/nyc-tlc-trip-records-pds/) without having to provide credentials (see aws s3 ls s3://nyc-tlc/ --no-sign-request)

There does not appear to be an equivalent for the Rust SDK.

Tell us about the problem you're trying to solve.

Access AWS Open Data, e.g. https://registry.opendata.aws/nyc-tlc-trip-records-pds/

Are you currently working around this issue?

No workaround.

Additional context

No response

@seddonm1 seddonm1 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 23, 2022
@rcoh
Copy link
Contributor

rcoh commented Jan 24, 2022

yeah that's correct. We actually considered the anonymous credentials route but it causes a lot of internal complexity because you now need to validate that every credential actually has credentials inside. I'm going to investigate how other SDKs handle this issue. We do support unauthenticated requests in the low-level client. SSO, for example, models certain requests as unauthenticated. I think we'll be able to build an ergonomic interface for this, potentially by adding an unauthenticated() method to the builder, eg.

As a (admittedly, not ergonomic workaround), you can use the low level client and augment the property bag:

use aws_sdk_s3::operation::ListObjectsV2;
use aws_sdk_s3::Credentials;
use aws_sig_auth::signer::OperationSigningConfig;
use aws_sig_auth::signer::SigningRequirements;
use aws_smithy_http::operation::Operation;

#[tokio::main]
async fn main() {
    let conf = aws_config::from_env()
        .credentials_provider(Credentials::new("stub", "stub", None, None, "faked"))
        .region("us-east-1")
        .load()
        .await;
    let conf = aws_sdk_s3::Config::new(&conf);
    let client = aws_smithy_client::Builder::dyn_https()
        .middleware(aws_sdk_s3::middleware::DefaultMiddleware::new())
        .build();
    let mut operation = ListObjectsV2::builder()
        .bucket("nyc-tlc")
        .build()
        .unwrap()
        .make_operation(&conf)
        .await
        .unwrap();
    make_unsigned(&mut operation);
    let resp = client
        .call(operation)
        .await
        .expect("request should succeed");
    for obj in resp.contents().unwrap_or_default() {
        println!("{}", obj.key().unwrap_or_default());
    }
}

// this function will work on any S3 operation
fn make_unsigned<I, R>(operation: &mut Operation<I, R>) {
    let mut props = operation.properties_mut();
    let mut signing_config = props
        .get_mut::<OperationSigningConfig>()
        .expect("has signing_config");
    signing_config.signing_requirements = SigningRequirements::Disabled;
}

@rcoh rcoh removed the needs-triage This issue or PR still needs to be triaged. label Jan 24, 2022
@seddonm1
Copy link
Author

Thank you for your thorough response @rcoh and I appreciate you providing a workaround.

I hope you are able to work out (as you say) a more ergonomic answer than this and potentially add it to the default credentials chain even if this is not necessarily a common requirement.

@Xuanwo
Copy link

Xuanwo commented Feb 24, 2022

Maybe we can change signing_config.signing_requirements in the DefaultMiddleware so that we don't need to make_unsigned for every operation.

@Xuanwo
Copy link

Xuanwo commented Mar 3, 2022

Hello, everyone here, I got it works via middleware: apache/opendal#97

No need to operate on a low-level request, everything works.

@rcoh Can you take a look at this PR? I'm willing to submit a PR back to aws-sdk-rust if there is an actionable route.

@Velfi
Copy link
Contributor

Velfi commented Mar 7, 2022

@Xuanwo Thanks for coming up with that suggestion. We'll take a look when we're able and get back to you.

@Velfi
Copy link
Contributor

Velfi commented Sep 8, 2022

This will soon be slightly easier to do pending the release of the changes from smithy-rs#1647:

#[tokio::main]
async fn main() {
    let conf = aws_config::load_from_env().await;
    let client = aws_sdk_s3::Client::new(&conf);
    let res = client
        .list_objects_v2()
        .bucket("genome-browser")
        .customize()
        .await
        .unwrap()
        .map_operation(make_unsigned)
        .unwrap()
        .send()
        .await
        .expect("request should succeed");

    for obj in res.contents().unwrap_or_default() {
        println!("{}", obj.key().unwrap_or_default());
    }
}

fn make_unsigned<O, Retry>(
    mut operation: aws_smithy_http::operation::Operation<O, Retry>,
) -> Result<aws_smithy_http::operation::Operation<O, Retry>, std::convert::Infallible> {
    {
        let mut props = operation.properties_mut();
        let mut signing_config = props
            .get_mut::<aws_sig_auth::signer::OperationSigningConfig>()
            .expect("has signing_config");
        signing_config.signing_requirements = aws_sig_auth::signer::SigningRequirements::Disabled;
    }

    Ok(operation)
}

The "Customizable Operations" feature will ship with versions 0.49.0/0.19.0 which will (famous last words) probably arrive some time next week.

@seddonm1
Copy link
Author

seddonm1 commented Sep 8, 2022

Thank you @Velfi . We can probably close this issue then?

@jdisanti
Copy link
Contributor

We can probably close this issue then?

Keeping this open because it seems like there should be an easier way to do this.

@jdisanti
Copy link
Contributor

jdisanti commented Dec 7, 2023

The aws-config now has a no_credentials() method on it to specify anonymous auth. If you're not using aws-config, then you can have the same behavior by not setting a credentials provider for services that support it.

@jdisanti jdisanti closed this as completed Dec 7, 2023
Copy link

github-actions bot commented Dec 7, 2023

鈿狅笍COMMENT VISIBILITY WARNING鈿狅笍

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

6 participants