Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark aws_sdk_rdsdata::client::Client::execute_sql as deprecated. #740

Closed
ThaddeusTreloar opened this issue Feb 16, 2023 · 3 comments
Closed
Labels
documentation This is a problem with documentation

Comments

@ThaddeusTreloar
Copy link

ThaddeusTreloar commented Feb 16, 2023

Describe the issue

Calling:

let aws_config = aws_config::load_from_env().await;
let rds_client = aws_sdk_rdsdata::Client::new(&aws_config);

let result = rds_client.execute_sql()
        .db_cluster_or_instance_arn(some_arn_str)
        .aws_secret_store_arn(some_secret_arn_str)
        .sql_statements(some_sql_str)
        .database(some_db_str)
        .send()
        .await?;

Results in:

ServiceError(
  ServiceError { 
    source: ExecuteSqlError { 
       kind: BadRequestException(
          BadRequestException { 
            message: Some("This API is deprecated and not available. Use ExecuteStatement API instead")
  }
)

At runtime.

I am assuming that this is directly referring to aws_sdk_rdsdata::client::Client::execute_sql as calling aws_sdk_rdsdata::client::Client::execute_statement does not produce the same result.

If this is the case, making the function as deprecated in the documentation would be helpful.

Links

https://docs.rs/aws-sdk-rdsdata/latest/aws_sdk_rdsdata/client/struct.Client.html#method.execute_sql

@ThaddeusTreloar ThaddeusTreloar added documentation This is a problem with documentation needs-triage This issue or PR still needs to be triaged. labels Feb 16, 2023
@Velfi Velfi removed the needs-triage This issue or PR still needs to be triaged. label Feb 16, 2023
@Velfi
Copy link
Contributor

Velfi commented Feb 16, 2023

Hey @ThaddeusTreloar, thanks for reporting this issue. I've submitted a fix in this PR.

@ThaddeusTreloar
Copy link
Author

Thanks @Velfi , I will mark this as closed!

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation
Projects
None yet
Development

No branches or pull requests

2 participants