Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Either httpAgent or httpsAgent are set, but not both #17

Closed
gamliela opened this issue Mar 28, 2023 · 2 comments
Closed

Either httpAgent or httpsAgent are set, but not both #17

gamliela opened this issue Mar 28, 2023 · 2 comments
Labels
bug Something isn't working released

Comments

@gamliela
Copy link

gamliela commented Mar 28, 2023

Current Behavior

According to the code, either httpAgent or httpsAgent are set, but never both.
However, aws-sdk v3 documentation clearly states:
"httpAgent is not the same as httpsAgent, and since most calls from the client will be to https, both should be set."
https://docs.aws.amazon.com/sdk-for-javascript/v3/developer-guide/node-configuring-proxies.html

Expected Behavior

If both http and https are provided, both should be passed on to the client.

Steps to Reproduce the Problem

Try use this package with AmazonConnect, which requires both.

Environment

  • Version: 0.0.0-development
  • Platform: Linux
  • Node.js Version: 18
@gamliela gamliela added the bug Something isn't working label Mar 28, 2023
@ryansonshine
Copy link
Contributor

Great catch @gamliela , I'll get an update out shortly.

@github-actions
Copy link

🎉 This issue has been resolved in version 2.0.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

No branches or pull requests

2 participants