Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature:Add optional argument to command line for accepting the Standards Warning #11

Open
charles545587 opened this issue May 22, 2019 · 3 comments

Comments

@charles545587
Copy link

charles545587 commented May 22, 2019

I am trying to run this via a CodePipeline Project, at the moment the task will fail as the code requires user input to accept the deployment of the CIS Benchmarks.

Could an additional positional argument be added to accept this allowing it to run without user input? for example

$python enablesecurityhub.py -y ${enablecsv} --master_account ${AdministratorAccountId} --assume_role ${CodeBuildManageSecurityHubRole} --enable_standards arn:aws:securityhub:::ruleset/cis-aws-foundations-benchmark/v/1.2.0

I will attempt to do this myself, but someone else might be able to perform a quicker fix.

@charles545587
Copy link
Author

I have made a work around by commenting out the check in the code.

@obijan42
Copy link
Contributor

Implemented here:
dde7836

@wallabyies
Copy link

It would be great if this feature could be implemented. Not having it makes automating this deployment impossible if the enabled_standards switch is used.

It looks like a solution for this has already been opened here:
#22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants