Skip to content

Commit

Permalink
adding unit tests
Browse files Browse the repository at this point in the history
  • Loading branch information
eamonnfaherty committed Sep 1, 2022
1 parent 5ef744a commit 5427f34
Show file tree
Hide file tree
Showing 19 changed files with 583 additions and 258 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,50 +2,58 @@
from servicecatalog_puppet.workflow import tasks_unit_tests_helper


class GetAllProductsAndTheirVersionsTaskTest(tasks_unit_tests_helper.PuppetTaskUnitTest):
class GetAllProductsAndTheirVersionsTaskTest(
tasks_unit_tests_helper.PuppetTaskUnitTest
):
account_id = "account_id"
region = "region"
portfolio = "portfolio"
portfolio_task_reference = "portfolio_task_reference"

def setUp(self) -> None:
from servicecatalog_puppet.workflow.portfolio.accessors import get_all_products_and_their_versions_task
from servicecatalog_puppet.workflow.portfolio.accessors import (
get_all_products_and_their_versions_task,
)

self.module = get_all_products_and_their_versions_task

self.sut = self.module.GetAllProductsAndTheirVersionsTask(
**self.get_common_args(),
account_id=self.account_id, region=self.region, portfolio=self.portfolio, portfolio_task_reference=self.portfolio_task_reference
account_id=self.account_id,
region=self.region,
portfolio=self.portfolio,
portfolio_task_reference=self.portfolio_task_reference,
)
self.wire_up_mocks()

self.wire_up_mocks()

def test_params_for_results_display(self):
# setup
expected_result = {
"task_reference": self.task_reference,
"cache_invalidator": self.cache_invalidator,
}
}

# exercise
actual_result = self.sut.params_for_results_display()

# verify
self.assertEqual(expected_result, actual_result)

def test_api_calls_used(self):
# setup
expected_result = [
f"servicecatalog.search_products_as_admin_{self.account_id}_{self.region}",
f"servicecatalog.describe_product_as_admin_{self.account_id}_{self.region}",
f"servicecatalog.describe_product_as_admin_{self.account_id}_{self.region}",
]
]

# exercise
actual_result = self.sut.api_calls_used()

# verify
self.assertEqual(expected_result, actual_result)

@skip
def test_run(self):
# setup
Expand All @@ -54,4 +62,3 @@ def test_run(self):

# verify
raise NotImplementedError()

Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
from servicecatalog_puppet.workflow import tasks_unit_tests_helper


class CreateAssociationsForSpokeLocalPortfolioTaskTest(tasks_unit_tests_helper.PuppetTaskUnitTest):
class CreateAssociationsForSpokeLocalPortfolioTaskTest(
tasks_unit_tests_helper.PuppetTaskUnitTest
):
portfolio_task_reference = "portfolio_task_reference"
spoke_local_portfolio_name = "spoke_local_portfolio_name"
account_id = "account_id"
Expand All @@ -11,15 +13,23 @@ class CreateAssociationsForSpokeLocalPortfolioTaskTest(tasks_unit_tests_helper.P
associations = []

def setUp(self) -> None:
from servicecatalog_puppet.workflow.portfolio.associations import create_associations_for_spoke_local_portfolio_task
from servicecatalog_puppet.workflow.portfolio.associations import (
create_associations_for_spoke_local_portfolio_task,
)

self.module = create_associations_for_spoke_local_portfolio_task

self.sut = self.module.CreateAssociationsForSpokeLocalPortfolioTask(
**self.get_common_args(),
portfolio_task_reference=self.portfolio_task_reference, spoke_local_portfolio_name=self.spoke_local_portfolio_name, account_id=self.account_id, region=self.region, portfolio=self.portfolio, associations=self.associations
portfolio_task_reference=self.portfolio_task_reference,
spoke_local_portfolio_name=self.spoke_local_portfolio_name,
account_id=self.account_id,
region=self.region,
portfolio=self.portfolio,
associations=self.associations,
)
self.wire_up_mocks()

self.wire_up_mocks()

def test_params_for_results_display(self):
# setup
Expand All @@ -30,27 +40,27 @@ def test_params_for_results_display(self):
"region": self.region,
"account_id": self.account_id,
"cache_invalidator": self.cache_invalidator,
}
}

# exercise
actual_result = self.sut.params_for_results_display()

# verify
self.assertEqual(expected_result, actual_result)

def test_api_calls_used(self):
# setup
expected_result = [
f"cloudformation.create_or_update_{self.account_id}_{self.region}",
f"cloudformation.describe_stacks_{self.account_id}_{self.region}",
]

# exercise
actual_result = self.sut.api_calls_used()

# verify
self.assertEqual(expected_result, actual_result)

@skip
def test_run(self):
# setup
Expand All @@ -59,4 +69,3 @@ def test_run(self):

# verify
raise NotImplementedError()

Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,30 @@
from servicecatalog_puppet.workflow import tasks_unit_tests_helper


class TerminateAssociationsForSpokeLocalPortfolioTaskTest(tasks_unit_tests_helper.PuppetTaskUnitTest):
class TerminateAssociationsForSpokeLocalPortfolioTaskTest(
tasks_unit_tests_helper.PuppetTaskUnitTest
):
account_id = "account_id"
region = "region"
portfolio = "portfolio"
spoke_local_portfolio_name = "spoke_local_portfolio_name"

def setUp(self) -> None:
from servicecatalog_puppet.workflow.portfolio.associations import terminate_associations_for_spoke_local_portfolio_task
from servicecatalog_puppet.workflow.portfolio.associations import (
terminate_associations_for_spoke_local_portfolio_task,
)

self.module = terminate_associations_for_spoke_local_portfolio_task

self.sut = self.module.TerminateAssociationsForSpokeLocalPortfolioTask(
**self.get_common_args(),
account_id=self.account_id, region=self.region, portfolio=self.portfolio, spoke_local_portfolio_name=self.spoke_local_portfolio_name
account_id=self.account_id,
region=self.region,
portfolio=self.portfolio,
spoke_local_portfolio_name=self.spoke_local_portfolio_name,
)
self.wire_up_mocks()

self.wire_up_mocks()

def test_params_for_results_display(self):
# setup
Expand All @@ -28,26 +36,26 @@ def test_params_for_results_display(self):
"region": self.region,
"account_id": self.account_id,
"cache_invalidator": self.cache_invalidator,
}
}

# exercise
actual_result = self.sut.params_for_results_display()

# verify
self.assertEqual(expected_result, actual_result)

def test_api_calls_used(self):
# setup
expected_result = [
f"cloudformation.ensure_deleted_{self.account_id}_{self.region}",
]
]

# exercise
actual_result = self.sut.api_calls_used()

# verify
self.assertEqual(expected_result, actual_result)

@skip
def test_run(self):
# setup
Expand All @@ -56,4 +64,3 @@ def test_run(self):

# verify
raise NotImplementedError()

Original file line number Diff line number Diff line change
Expand Up @@ -2,25 +2,38 @@
from servicecatalog_puppet.workflow import tasks_unit_tests_helper


class CreateLaunchRoleConstraintsForSpokeLocalPortfolioTaskTest(tasks_unit_tests_helper.PuppetTaskUnitTest):
class CreateLaunchRoleConstraintsForSpokeLocalPortfolioTaskTest(
tasks_unit_tests_helper.PuppetTaskUnitTest
):
portfolio_task_reference = "portfolio_task_reference"
spoke_local_portfolio_name = "spoke_local_portfolio_name"
account_id = "account_id"
region = "region"
portfolio = "portfolio"
launch_constraints = []
portfolio_get_all_products_and_their_versions_ref = "portfolio_get_all_products_and_their_versions_ref"
portfolio_get_all_products_and_their_versions_ref = (
"portfolio_get_all_products_and_their_versions_ref"
)

def setUp(self) -> None:
from servicecatalog_puppet.workflow.portfolio.constraints_management import create_launch_role_constraints_for_spoke_local_portfolio_task
from servicecatalog_puppet.workflow.portfolio.constraints_management import (
create_launch_role_constraints_for_spoke_local_portfolio_task,
)

self.module = create_launch_role_constraints_for_spoke_local_portfolio_task

self.sut = self.module.CreateLaunchRoleConstraintsForSpokeLocalPortfolioTask(
**self.get_common_args(),
portfolio_task_reference=self.portfolio_task_reference, spoke_local_portfolio_name=self.spoke_local_portfolio_name, account_id=self.account_id, region=self.region, portfolio=self.portfolio, launch_constraints=self.launch_constraints, portfolio_get_all_products_and_their_versions_ref=self.portfolio_get_all_products_and_their_versions_ref
portfolio_task_reference=self.portfolio_task_reference,
spoke_local_portfolio_name=self.spoke_local_portfolio_name,
account_id=self.account_id,
region=self.region,
portfolio=self.portfolio,
launch_constraints=self.launch_constraints,
portfolio_get_all_products_and_their_versions_ref=self.portfolio_get_all_products_and_their_versions_ref,
)
self.wire_up_mocks()

self.wire_up_mocks()

def test_params_for_results_display(self):
# setup
Expand All @@ -31,26 +44,26 @@ def test_params_for_results_display(self):
"region": self.region,
"account_id": self.account_id,
"cache_invalidator": self.cache_invalidator,
}
}

# exercise
actual_result = self.sut.params_for_results_display()

# verify
self.assertEqual(expected_result, actual_result)

def test_api_calls_used(self):
# setup
expected_result = [
f"cloudformation.create_or_update_{self.account_id}_{self.region}",
]
]

# exercise
actual_result = self.sut.api_calls_used()

# verify
self.assertEqual(expected_result, actual_result)

@skip
def test_run(self):
# setup
Expand All @@ -59,4 +72,3 @@ def test_run(self):

# verify
raise NotImplementedError()

0 comments on commit 5427f34

Please sign in to comment.