adding unit tests

awslabs · Aug 31, 2022 · d214e8a · d214e8a
1 parent 3ce86e9
commit d214e8a
Show file tree

Hide file tree

Showing 18 changed files with 476 additions and 118 deletions.
diff --git a/...alog_puppet/workflow/service_control_policies/do_execute_service_control_policies_task.py b/...alog_puppet/workflow/service_control_policies/do_execute_service_control_policies_task.py
@@ -17,7 +17,6 @@
 
 class DoExecuteServiceControlPoliciesTask(tasks.TaskWithReference):
     service_control_policy_name = luigi.Parameter()
-    puppet_account_id = luigi.Parameter()
     region = luigi.Parameter()
     account_id = luigi.Parameter()
     ou_name = luigi.Parameter()

diff --git a/...puppet/workflow/service_control_policies/do_execute_service_control_policies_task_test.py b/...puppet/workflow/service_control_policies/do_execute_service_control_policies_task_test.py
@@ -0,0 +1,83 @@
+from unittest import skip
+from servicecatalog_puppet.workflow import tasks_unit_tests_helper
+
+
+class DoExecuteServiceControlPoliciesTaskTest(
+    tasks_unit_tests_helper.PuppetTaskUnitTest
+):
+    service_control_policy_name = "service_control_policy_name"
+    region = "region"
+    account_id = "account_id"
+    ou_name = "ou_name"
+    content = {}
+    description = "description"
+    manifest_file_path = "manifest_file_path"
+    requested_priority = 1
+
+    def setUp(self) -> None:
+        from servicecatalog_puppet.workflow.service_control_policies import (
+            do_execute_service_control_policies_task,
+        )
+
+        self.module = do_execute_service_control_policies_task
+
+        self.sut = self.module.DoExecuteServiceControlPoliciesTask(
+            **self.get_common_args(),
+            service_control_policy_name=self.service_control_policy_name,
+            region=self.region,
+            account_id=self.account_id,
+            ou_name=self.ou_name,
+            content=self.content,
+            description=self.description,
+            manifest_file_path=self.manifest_file_path,
+            requested_priority=self.requested_priority,
+        )
+
+        self.wire_up_mocks()
+
+    def test_params_for_results_display(self):
+        # setup
+        expected_result = {
+            "puppet_account_id": self.puppet_account_id,
+            "service_control_policy_name": self.service_control_policy_name,
+            "region": self.region,
+            "account_id": self.account_id,
+            "ou_name": self.ou_name,
+            "cache_invalidator": self.cache_invalidator,
+        }
+
+        # exercise
+        actual_result = self.sut.params_for_results_display()
+
+        # verify
+        self.assertEqual(expected_result, actual_result)
+
+    @skip
+    def test_requires(self):
+        # setup
+        # exercise
+        actual_result = self.sut.requires()
+
+        # verify
+        raise NotImplementedError()
+
+    def test_api_calls_used(self):
+        # setup
+        expected_result = [
+            f"organizations.attach_policy_{self.region}",
+        ]
+
+        # exercise
+        actual_result = self.sut.api_calls_used()
+
+        # verify
+        self.assertEqual(expected_result, actual_result)
+
+    @skip
+    def test_run(self):
+        # setup
+        # exercise
+        actual_result = self.sut.run()
+
+        # verify
+        raise NotImplementedError()
diff --git a/...og_puppet/workflow/service_control_policies/do_terminate_service_control_policies_task.py b/...og_puppet/workflow/service_control_policies/do_terminate_service_control_policies_task.py
@@ -17,7 +17,6 @@
 
 class DoTerminateServiceControlPoliciesTask(tasks.TaskWithReference):
     service_control_policy_name = luigi.Parameter()
-    puppet_account_id = luigi.Parameter()
 
     region = luigi.Parameter()
     account_id = luigi.Parameter()

diff --git a/...ppet/workflow/service_control_policies/do_terminate_service_control_policies_task_test.py b/...ppet/workflow/service_control_policies/do_terminate_service_control_policies_task_test.py
@@ -0,0 +1,83 @@
+from unittest import skip
+from servicecatalog_puppet.workflow import tasks_unit_tests_helper
+
+
+class DoTerminateServiceControlPoliciesTaskTest(
+    tasks_unit_tests_helper.PuppetTaskUnitTest
+):
+    service_control_policy_name = "service_control_policy_name"
+    region = "region"
+    account_id = "account_id"
+    ou_name = "ou_name"
+    content = {}
+    description = "description"
+    manifest_file_path = "manifest_file_path"
+    requested_priority = 1
+
+    def setUp(self) -> None:
+        from servicecatalog_puppet.workflow.service_control_policies import (
+            do_terminate_service_control_policies_task,
+        )
+
+        self.module = do_terminate_service_control_policies_task
+
+        self.sut = self.module.DoTerminateServiceControlPoliciesTask(
+            **self.get_common_args(),
+            service_control_policy_name=self.service_control_policy_name,
+            region=self.region,
+            account_id=self.account_id,
+            ou_name=self.ou_name,
+            content=self.content,
+            description=self.description,
+            manifest_file_path=self.manifest_file_path,
+            requested_priority=self.requested_priority,
+        )
+
+        self.wire_up_mocks()
+
+    def test_params_for_results_display(self):
+        # setup
+        expected_result = {
+            "puppet_account_id": self.puppet_account_id,
+            "service_control_policy_name": self.service_control_policy_name,
+            "region": self.region,
+            "account_id": self.account_id,
+            "ou_name": self.ou_name,
+            "cache_invalidator": self.cache_invalidator,
+        }
+
+        # exercise
+        actual_result = self.sut.params_for_results_display()
+
+        # verify
+        self.assertEqual(expected_result, actual_result)
+
+    @skip
+    def test_requires(self):
+        # setup
+        # exercise
+        actual_result = self.sut.requires()
+
+        # verify
+        raise NotImplementedError()
+
+    def test_api_calls_used(self):
+        # setup
+        expected_result = [
+            f"organizations.detach_policy_{self.region}",
+        ]
+
+        # exercise
+        actual_result = self.sut.api_calls_used()
+
+        # verify
+        self.assertEqual(expected_result, actual_result)
+
+    @skip
+    def test_run(self):
+        # setup
+        # exercise
+        actual_result = self.sut.run()
+
+        # verify
+        raise NotImplementedError()
diff --git a/servicecatalog_puppet/workflow/simulate_policies/do_execute_simulate_policy_task_test.py b/servicecatalog_puppet/workflow/simulate_policies/do_execute_simulate_policy_task_test.py
@@ -0,0 +1,89 @@
+from unittest import skip
+from servicecatalog_puppet.workflow import tasks_unit_tests_helper
+
+
+class DoExecuteSimulatePolicyTaskTest(tasks_unit_tests_helper.PuppetTaskUnitTest):
+    simulate_policy_name = "simulate_policy_name"
+    region = "region"
+    account_id = "account_id"
+    execution = "execution"
+    simulation_type = "simulation_type"
+    policy_source_arn = "policy_source_arn"
+    policy_input_list = []
+    permissions_boundary_policy_input_list = []
+    action_names = []
+    expected_decision = "expected_decision"
+    resource_arns = []
+    resource_policy = "resource_policy"
+    resource_owner = "resource_owner"
+    caller_arn = "caller_arn"
+    context_entries = []
+    resource_handling_option = "resource_handling_option"
+    requested_priority = 1
+
+    def setUp(self) -> None:
+        from servicecatalog_puppet.workflow.simulate_policies import (
+            do_execute_simulate_policy_task,
+        )
+
+        self.module = do_execute_simulate_policy_task
+
+        self.sut = self.module.DoExecuteSimulatePolicyTask(
+            **self.get_common_args(),
+            simulate_policy_name=self.simulate_policy_name,
+            region=self.region,
+            account_id=self.account_id,
+            execution=self.execution,
+            simulation_type=self.simulation_type,
+            policy_source_arn=self.policy_source_arn,
+            policy_input_list=self.policy_input_list,
+            permissions_boundary_policy_input_list=self.permissions_boundary_policy_input_list,
+            action_names=self.action_names,
+            expected_decision=self.expected_decision,
+            resource_arns=self.resource_arns,
+            resource_policy=self.resource_policy,
+            resource_owner=self.resource_owner,
+            caller_arn=self.caller_arn,
+            context_entries=self.context_entries,
+            resource_handling_option=self.resource_handling_option,
+            requested_priority=self.requested_priority,
+        )
+
+        self.wire_up_mocks()
+
+    def test_params_for_results_display(self):
+        # setup
+        expected_result = {
+            "puppet_account_id": self.puppet_account_id,
+            "simulate_policy_name": self.simulate_policy_name,
+            "region": self.region,
+            "account_id": self.account_id,
+            "cache_invalidator": self.cache_invalidator,
+        }
+
+        # exercise
+        actual_result = self.sut.params_for_results_display()
+
+        # verify
+        self.assertEqual(expected_result, actual_result)
+
+    def test_api_calls_used(self):
+        # setup
+        expected_result = [
+            f"iam.simulate_{self.simulation_type}_policy_{self.account_id}_{self.region}"
+        ]
+
+        # exercise
+        actual_result = self.sut.api_calls_used()
+
+        # verify
+        self.assertEqual(expected_result, actual_result)
+
+    @skip
+    def test_run(self):
+        # setup
+        # exercise
+        actual_result = self.sut.run()
+
+        # verify
+        raise NotImplementedError()
diff --git a/servicecatalog_puppet/workflow/stack/create_template_for_stack_task.py b/servicecatalog_puppet/workflow/stack/create_template_for_stack_task.py
@@ -9,7 +9,7 @@
 from servicecatalog_puppet.workflow import tasks
 
 
-class CreateTemplateForStackTask(tasks.PuppetTask): #TODO make task with reference
+class CreateTemplateForStackTask(tasks.PuppetTask):  # TODO make task with reference
     def params_for_results_display(self):
         return {
             "cache_invalidator": self.cache_invalidator,

diff --git a/servicecatalog_puppet/workflow/stack/get_cloud_formation_template_from_s3_test.py b/servicecatalog_puppet/workflow/stack/get_cloud_formation_template_from_s3_test.py
@@ -10,15 +10,22 @@ class GetCloudFormationTemplateFromS3Test(tasks_unit_tests_helper.PuppetTaskUnit
     version_id = "version_id"
 
     def setUp(self) -> None:
-        from servicecatalog_puppet.workflow.stack import get_cloud_formation_template_from_s3
+        from servicecatalog_puppet.workflow.stack import (
+            get_cloud_formation_template_from_s3,
+        )
+
         self.module = get_cloud_formation_template_from_s3
-        
+
         self.sut = self.module.GetCloudFormationTemplateFromS3(
             **self.get_common_args(),
-            account_id=self.account_id, bucket=self.bucket, key=self.key, region=self.region, version_id=self.version_id        
+            account_id=self.account_id,
+            bucket=self.bucket,
+            key=self.key,
+            region=self.region,
+            version_id=self.version_id,
         )
-        
-        self.wire_up_mocks()    
+
+        self.wire_up_mocks()
 
     def test_params_for_results_display(self):
         # setup
@@ -29,14 +36,14 @@ def test_params_for_results_display(self):
             "region": self.region,
             "version_id": self.version_id,
             "cache_invalidator": self.cache_invalidator,
-        }        
-    
+        }
+
         # exercise
         actual_result = self.sut.params_for_results_display()
-        
+
         # verify
         self.assertEqual(expected_result, actual_result)
-    
+
     @skip
     def test_run(self):
         # setup
@@ -45,4 +52,3 @@ def test_run(self):
 
         # verify
         raise NotImplementedError()
-
diff --git a/servicecatalog_puppet/workflow/stack/prepare_account_for_stack_task.py b/servicecatalog_puppet/workflow/stack/prepare_account_for_stack_task.py
@@ -8,7 +8,7 @@
 from servicecatalog_puppet.workflow.stack import create_template_for_stack_task
 
 
-class PrepareAccountForWorkspaceTask(tasks.PuppetTask): #TODO make task with reference
+class PrepareAccountForWorkspaceTask(tasks.PuppetTask):  # TODO make task with reference
     account_id = luigi.Parameter()
 
     def params_for_results_display(self):