Skip to content
This repository has been archived by the owner on Nov 7, 2019. It is now read-only.

Configmaps for services other than s3 missing #131

Open
jgryszko opened this issue Oct 23, 2018 · 5 comments
Open

Configmaps for services other than s3 missing #131

jgryszko opened this issue Oct 23, 2018 · 5 comments
Labels
good first issue kind/bug Something isn't working

Comments

@jgryszko
Copy link

Is it planned to create config maps for other services than s3 (sqs, sns ...), or is there any reason, why it was omitted? Looking for areas to contribute...

@christopherhein christopherhein added kind/bug Something isn't working good first issue labels Oct 23, 2018
@christopherhein
Copy link
Contributor

There is not a reason, this would be a great first issue :)

@ivanich
Copy link
Contributor

ivanich commented Feb 10, 2019

@christopherhein Any update on this? I've tried to add corresponding additional resource to sqsqueue.yaml model and rebuild aws-service-operator but it still doesn't create configmap for sqs.
Basically what I tried so far:

  additionalResources:
    configMaps:
    - name: sqsCM
      data:
      - key: queueARN
        value: "{{.Obj.Output.QueueARN}}"
      - key: queueName
        value: "{{.Obj.Output.QueueName}}"
      - key: queueURL
        value: "{{.Obj.Output.QueueURL}}"

and then run "make rebuld" to regenerate and build code. Am I miss something?

@ivanich
Copy link
Contributor

ivanich commented Feb 12, 2019

Turned out it never used my edited code but used unmodified sources from vendor dir.

@christopherhein
Copy link
Contributor

Turned out it never used my edited code but used unmodified sources from vendor dir.

So you have it working?

@ivanich
Copy link
Contributor

ivanich commented Feb 12, 2019

Turned out it never used my edited code but used unmodified sources from vendor dir.

So you have it working?

Yes, for some reason sources from vendor/github.com/awslabs/aws-service-operator/ was used.
It would be nice to see configmap support for all resources in upstream as well as helm charts repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants