This repository has been archived by the owner on Nov 7, 2019. It is now read-only.
Minor Makefile Tweak #127
Merged
Minor Makefile Tweak #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherhein
approved these changes
Oct 22, 2018
christopherhein
added
lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: This shifts the logic of how to install the code generation components into the Makefile for the code generation code. It also will rebuild the code generation tool before installing. This ensures the latest templates are bundled and included in the binary before use.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.