fix(aws-eventbridge-sns): long sns topic names break eventbridge bindings #1024
Conversation
biffgaut
requested review from
hayesry,
mobri2a,
emcfins,
mickychetta and
georgebearden
as code owners
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| @@ -141,7 +141,7 @@ test('check if the event rule has permission/policy in place in sns for it to be | |||
| ); | |||
| }); | |||
|
|
|||
| test('check events rule properties', () => { | |||
| test.only('check events rule properties', () => { | |||
There was a problem hiding this comment.
.only was probably left here accidentally?
There was a problem hiding this comment.
oops - I knew I was gonna forget that...
| import { generateIntegStackName } from '@aws-solutions-constructs/core'; | ||
|
|
||
| const app = new App(); | ||
| const stack = new Stack(app, generateIntegStackName(__filename) + 'ThisIsTheLongestNameForAStackItMustBeGreaterThanSixtyFourCharactersLongAndThisShouldJustAboutDoItNoItMustBeABitLonger'); |
There was a problem hiding this comment.
The dedication! I would have just lksjdfjoi3oio1ilkmslkdko...
|
|
||
| const app = new App(); | ||
|
|
||
| const stackTwo = new Stack(app, generateIntegStackName(__filename) + 'ThisIsTheLongestNameForAStackItMustBeGreaterThanSixtyFourCharactersLongAndThisShouldJustAboutDoItNoItMustBeABitLessShort'); |
There was a problem hiding this comment.
I see what you are doing here, but would it not be possible to launch both stacks from the same file? No issues if not, just curious as it may make it harder for a regression to slip through in the future if one forgets to launch the other stack?
There was a problem hiding this comment.
No, cdk-integ will only manage 1 stack - if the file has 2 you need to have a specific comment instructing cdk-integ which stack to launch
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue #, if available:
Closes #1015
Description of changes:
Explicitly set the physical name of the Event/Topic binding
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.