feat(cloudfront constructs): add s3 access logging to cloudfront access log buckets by default #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biffgaut
requested review from
hayesry,
mobri2a,
emcfins,
mickychetta and
georgebearden
as code owners
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| @@ -19,82 +19,14 @@ | |||
| # a sleep 10 command before the end of the loop to keep from overwhelming CloudFormation | |||
|
|
|||
| export constructs=" | |||
| aws-alb-fargate | |||
There was a problem hiding this comment.
was removing these intentional?
georgebearden
previously approved these changes
Dec 13, 2023
georgebearden
approved these changes
Dec 13, 2023
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Addresses Issue #1041
Description of changes:
Adds s3 access logging to the CloudFront log buckets by default
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.