Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cognito UserPoolDomain must be globally unique #54

Closed
1 of 2 tasks
mobri2a opened this issue Sep 3, 2020 · 1 comment
Closed
1 of 2 tasks

Cognito UserPoolDomain must be globally unique #54

mobri2a opened this issue Sep 3, 2020 · 1 comment
Assignees
@hnishar
Labels
enhancement New feature or request

Comments

@mobri2a
Copy link

mobri2a commented Sep 3, 2020

currently, cognito-helper sets up a Cognito::UserPoolDomain with the domain ID of the ElasticSearch domain (when used with aws-lambda-elasticsearch-kibana). While the Elasticsearch domain does not have to be globally unique, the Cognito domain does.

Use Case

Using the aws-lambda-elasticsearch-kibana pattern, one must ensure that both the ES and Cognito UserPoolDomain are globally unique, otherwise must use addPropertyOverride on the UserPoolDomain to make it unique, such as by appending the AWS account Id

Proposed Solution

Allow the user to provide Cognito parameters (similar to ES) at the Solution Construct. Use the ES domain with the account Id appended as a reasonable default.

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@mobri2a mobri2a added feature-request A feature should be added or improved needs-triage The issue or PR still needs to be triaged labels Sep 3, 2020
@hnishar hnishar added enhancement New feature or request in-progress This issue is being actively worked on and removed feature-request A feature should be added or improved needs-triage The issue or PR still needs to be triaged labels Sep 10, 2020
@hnishar hnishar self-assigned this Sep 17, 2020
@hnishar
Copy link
Contributor

hnishar commented Sep 24, 2020

This has been fixed in v1.64.0

@hnishar hnishar closed this as completed Sep 24, 2020
@hnishar hnishar removed the in-progress This issue is being actively worked on label Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hnishar hnishar

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mobri2a @hnishar