fix(lib): names generated using non-FIPS compliant algorithm #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 18, 2020 22:37
The CDK8s name generator (`Names.toLabelValue()` and `Names.toDnsLabel()`) have used sha256, which cannot be used in environments that are FIPS compliant. To fix this, we are now using the [recently introduced](aws/constructs#314) `Node.of(construct).addr` as the hash postfix of generated names. Fixes #334 BREAKING CHANGE: CAUTION! Auto-generated resource names will change with this release. Resource names in manifests synthesized by a previous version of the CDK8s will be invalidated. Deploying new manifests will cause **resources to be replaced**. Temporarily, you can opt to use the legacy hashing mechanism by setting the environment variable `CDK8S_LEGACY_HASH=1`. * **core:** `Names.toDnsLabel()` now accepts a construct scope instead of a string path, and a set of options instead of `maxLen`. * **core:** `Names.toLabelValue()` now accepts a construct scope instead of a string path, and a set of options instead of `maxLen`.
eladb
changed the title
iliapolo
previously approved these changes
Nov 18, 2020
|
Your pull request will be updated and merged automatically (do not update manually). |
mergify
bot
dismissed
iliapolo’s stale review
Pull request has been modified.
added 10 commits
November 18, 2020 23:26
iliapolo
previously approved these changes
Nov 19, 2020
|
Your pull request will be updated and merged automatically (do not update manually). |
mergify
bot
dismissed
iliapolo’s stale review
Pull request has been modified.
iliapolo
approved these changes
Nov 19, 2020
|
Your pull request will be updated and merged automatically (do not update manually). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CDK8s name generator (
Names.toLabelValue()andNames.toDnsLabel()) have used sha256, which cannot be used in environments that are FIPS compliant.To fix this, we are now using the recently introduced
Node.of(construct).addras the hash postfix of generated names.Fixes #334
BREAKING CHANGE: CAUTION! Auto-generated resource names will change with this release. Resource names in manifests synthesized by a previous version of the CDK8s will be invalidated. Deploying new manifests will cause resources to be replaced. Temporarily, you can opt to use the legacy hashing mechanism by setting the environment variable
CDK8S_LEGACY_HASH=1.Names.toDnsLabel()now accepts a construct scope instead of a string path, and a set of options instead ofmaxLen.Names.toLabelValue()now accepts a construct scope instead of a string path, and a set of options instead ofmaxLen.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license