feat: experimental golang bindings #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Publishes experimental Golang bindings for CDK8s under `github.com/awslabs/cdk8s-go/cdk8s` and `github.com/awslabs/cdk8s-go/cdk8splus17`
eladb
changed the title
added 2 commits
February 1, 2021 14:45
added 9 commits
February 3, 2021 17:56
iliapolo
approved these changes
Feb 4, 2021
Comment on lines
-37
to
-39
| "@types/node": "^10.17.50", | ||
| "@typescript-eslint/eslint-plugin": "^4.11.1", | ||
| "@typescript-eslint/parser": "^4.11.1", |
There was a problem hiding this comment.
How come these were downgraded?
There was a problem hiding this comment.
They are hard-coded in projen so whenever you run projen they get updated. But the important part is yarn.lock, no?
|
Your pull request will be updated and merged automatically (do not update manually). |
eladb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build & publishes experimental Go bindings for CDK8s under
github.com/awslabs/cdk8s-go/cdk8sandgithub.com/awslabs/cdk8s-go/cdk8splus17.This required the following changes:
publishToGodefinitions tocdk8sandcdk8s-plus-17_as a parameter name due to go: parameters named "_" result in invalid code aws/jsii#2530Resolves aws/jsii#2444
Resolves aws/jsii#2454
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license