Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(examples): "replicas" option is not respected in the web-service example #87

Merged
merged 1 commit into from
Mar 30, 2020
Merged

fix(examples): "replicas" option is not respected in the web-service example #87

merged 1 commit into from
Mar 30, 2020

Conversation

cmdallas
Copy link
Contributor

No description provided.

eladb
eladb suggested changes Mar 29, 2020
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Please fix PR title and description to adhere to conventional commits per the contribution guide.

examples/web-service/web-service.ts Outdated Show resolved Hide resolved
@cmdallas cmdallas force-pushed the patch-1 branch 2 times, most recently from 76d6c31 to cf006a0 Compare March 29, 2020 10:34
@eladb eladb changed the title Get replicas from options. fix(examples): "replicas" option is not respected in the web-service example Mar 30, 2020
@eladb eladb merged commit 97ca582 into cdk8s-team:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmdallas @eladb