Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using 'discover' #336

Merged
merged 1 commit into from
Sep 11, 2018
Merged

Stop using 'discover' #336

merged 1 commit into from
Sep 11, 2018

Conversation

adamchainz
Copy link
Contributor

I discovered that discover is a backport of the Python 2.7 unittest discover runner, since only Python 2.7+ is supported (or at least tested, I couldn't find documentation on that), use the standard library version instead.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kddejong
Copy link
Contributor

Looks like a lot more comments in the Travis build. I want to dig into this first.
https://travis-ci.com/awslabs/cfn-python-lint/jobs/144978155

@adamchainz
Copy link
Contributor Author

Oh yeah unittest doesn't do stdout/stderr capture, looks like discover does. I'd suggest moving to pytest for features like that and more. I use on all my projects - it can run unittest suites with no alterations.

@adamchainz adamchainz mentioned this pull request Sep 11, 2018
I discovered that [discover](https://pypi.org/project/discover/) is a backport of the Python 2.7 unittest discover runner, since only Python 2.7+ is supported (or at least tested, I couldn't find documentation on that), use the standard library version instead.
Copy link
Contributor

@kddejong kddejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kddejong kddejong merged commit 849b111 into aws-cloudformation:master Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants