Add support for Python3! #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit just makes the chalice codebase run on python3. There's no integration yet with creating python3 functions on lambda in this commit. Pylint doesn't officially support python3.6 yet, so I had to lock to a commit in their master branch for the time being. Once they support py36 in an official release I can update the requirements-dev.txt file. Passes all the tests/linters on python3.6.
This will update the python runtime on both the initial deploy as well as subsequent deploys.
This adds an api call for getting function configuration and updates the lambda deployer to use this new api call to check if the python runtime is about to change. If it is, it will prompt you for confirmation.
Right now this is a soft warning, but we may eventually make this a hard fail. Validation happens in two spots: * When running "chalice deploy" * When creating a new-project The `warnings` module is being used because I'm considering making this a hard fail, in which case I would update this to be a DeprecationWarning before actually removing this functionality.
stealthycoin
approved these changes
Apr 18, 2017
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
==========================================
+ Coverage 87.17% 87.32% +0.14%
==========================================
Files 19 19
Lines 1778 1814 +36
Branches 207 211 +4
==========================================
+ Hits 1550 1584 +34
- Misses 176 178 +2
Partials 52 52
Continue to review full report at Codecov.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will automatically set the python runtime based on the python version you're currently running.