Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min/Max String Length Analyzer #45

Closed
stefan-grafberger opened this issue Sep 27, 2018 · 11 comments
Closed

Min/Max String Length Analyzer #45

stefan-grafberger opened this issue Sep 27, 2018 · 11 comments
Labels
enhancement New feature or request

Comments

@stefan-grafberger
Copy link
Contributor

No description provided.

@stefan-grafberger stefan-grafberger added the enhancement New feature or request label Sep 27, 2018
@paulsukow
Copy link
Contributor

paulsukow commented Apr 25, 2019

I need this for my use case of deequ and currently working on a pr for this. I should have it ready some time next week

@patchrick843
Copy link

Has there been any movement on this at all? Curious for a project I am currently working on.

@sscdotopen
Copy link
Contributor

Not yet unfortunately, but it should not take too much effort to implement this, would you like to give it a try?

@patchrick843
Copy link

@sscdotopen I would like to give it a try, I think you are right wouldn't take too much effort. Did you have any suggestion on how you would like this implemented. I am going to create a fork today and try and get started.

@patchrick843
Copy link

It actually looks like @paulsukow has completed almost all of the work for this enhancement but never submitted a PR.

@paulsukow
Copy link
Contributor

I got side tracked and never got back to it.
This branch has what I started on it. I think it is almost done and just needs some tests or something
https://github.com/paulsukow/deequ/tree/enhancement/minMaxLengthAnalyzer

@paulsukow
Copy link
Contributor

paulsukow commented Aug 5, 2019

I can look into where I left off this week or @patchrick843 could take a look if he needs it sooner

@patchrick843
Copy link

I was able to find a work around for my current situation using
.hasPattern("last_name","""^[a-zA-Z0-9_].{0,15}$""".r)
I would be interested in helping finish up what @paulsukow has started. Let me know when you have taken a look and have an idea of what needs to be finished up. Thanks again.

@sscdotopen
Copy link
Contributor

@patchrick843 @paulsukow can you issue a PR so that we can have a look at the current state of the contribution?

@paulsukow
Copy link
Contributor

paulsukow commented Aug 9, 2019

work in progress pr: #122

@sscdotopen
Copy link
Contributor

PR merged, closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants