Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The loss function issue which is not the same as TransE #109

Closed
Zarca opened this issue Jun 9, 2020 · 1 comment
Closed

The loss function issue which is not the same as TransE #109

Zarca opened this issue Jun 9, 2020 · 1 comment

Comments

@Zarca
Copy link

Zarca commented Jun 9, 2020

Hi,
These days I have been using the out-of-box TransE algorithm come with DGL-KE , thanks for your excellent and kind work !
However, I also encountered a quesion about the loss funciton while I am tracing down to the source code about it in the:
dklke/models/general_models.py in method forward, lines between 370 and 399 as figures listed below:

DGL_ISSUE

DGL_ISSUE2

It seems that it's NOT consistent with the loss function described in the paper on dgl-ke's official github homepage, as the figure showed below:

DGL_ISSUE4

In this paper, the loss you author declared to be usued has just these 2 forms as below:
DGL_ISSUE3

but is not the same with the implemented as I mentioned above in dgk-ke's source code,
so I'm wondering that why the source code of general_models.py has changed the loss form?
Dose it make any improvement compared with the oringinal two kind of loss function in your paper?

Looking forward your reply

@classicsong
Copy link
Contributor

The adversarial sampling is in 3.3 Negative sampling in the paper.
It is not a uniform sampling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants