Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

fix: ISSUE-639 enabled reuse of https sockets in the aws-sdk #640

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

Zambonilli
Copy link
Contributor

Issue #, if available:
ISSUE-639
Description of changes:
Enabled the reuse of https sockets in all lambdas in the aws-sdk.

Checklist:

  • Have you successfully deployed to an AWS account with your changes?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Zambonilli Zambonilli requested a review from a team as a code owner June 15, 2022 15:33
@rsmayda
Copy link
Contributor

rsmayda commented Jun 15, 2022

Thanks for submitting could you update the branch to be in line with develop?

Also could you add a bit to this PR description on how this variable will be used?

@Zambonilli
Copy link
Contributor Author

AWS_NODEJS_CONNECTION_REUSE_ENABLED is used by the nodejs aws-sdk to indicate that it should create and use https socket pool instead of creating a new https socket on every aws-sdk service request. The environment variable is documented in documentation for nodejs considerations in the aws-sdk here.

@kpark277 kpark277 merged commit 432d4a8 into awslabs:develop Jun 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants